Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6281][PY] Add lint rules and action lint checks #6341

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sudohainguyen
Copy link
Contributor

@sudohainguyen sudohainguyen commented Apr 27, 2024

🔍 Description

Issue References 🔗

This pull request fixes #6281

Describe Your Solution 🔧

As part of our efforts to introduce python client built on top of Dropbox's PyHive, I've initialized some linting rules to check with github actions.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Code was following flake8 default format which is not sufficient

Behavior With This Pull Request 🎉

Lint checks now are powered by ruff


Checklist 📝

Be nice. Be informative.

@sudohainguyen sudohainguyen changed the title [KYUUBI #6281][PY] Add lint rules and update dev dependencies [KYUUBI #6281][PY] Add lint rules and update python dev dependencies Apr 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.48%. Comparing base (02e1aa3) to head (2e6c3ff).

❗ Current head 2e6c3ff differs from pull request most recent head e3b7598. Consider uploading reports for the commit e3b7598 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6341      +/-   ##
============================================
- Coverage     58.49%   58.48%   -0.02%     
  Complexity       24       24              
============================================
  Files           653      653              
  Lines         39974    39974              
  Branches       5489     5489              
============================================
- Hits          23384    23379       -5     
- Misses        14080    14091      +11     
+ Partials       2510     2504       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793
Copy link
Member

pan3793 commented Apr 28, 2024

I'm not sure we should apply new code-style rules at the current stage, I think we should postpone such things at least until the first release is completed. The most urgent thing is setting up CI to run the python test to ensure our ongoing changes won't break the code.

@sudohainguyen
Copy link
Contributor Author

sure we can get back to this PR later

however, I'm facing an authentication error installing CDH and trying docker-compose as another approach

@pan3793
Copy link
Member

pan3793 commented Apr 28, 2024

we can use the Apache version for testing.

this project may help you to choose the version combination

@github-actions github-actions bot added the kind:infra license, community building, project builds, asf infra related, etc. label May 7, 2024
@sudohainguyen sudohainguyen force-pushed the pyhive-ci branch 2 times, most recently from a1e772a to 98c3192 Compare May 7, 2024 15:42
@sudohainguyen sudohainguyen changed the title [KYUUBI #6281][PY] Add lint rules and update python dev dependencies [KYUUBI #6281][PY] Add lint rules and action lint checks May 7, 2024
@sudohainguyen
Copy link
Contributor Author

@pan3793 think we can resume this PR 😄

Signed-off-by: Harry <quanghai.ng1512@gmail.com>
Signed-off-by: Harry <quanghai.ng1512@gmail.com>
@github-actions github-actions bot removed the kind:infra license, community building, project builds, asf infra related, etc. label May 15, 2024
Signed-off-by: Harry <quanghai.ng1512@gmail.com>
@github-actions github-actions bot added the kind:infra license, community building, project builds, asf infra related, etc. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:infra license, community building, project builds, asf infra related, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK][MEDIUM] Setup GitHub Actions for Kyuubi Python client (former PyHive)
3 participants