[KYUUBI #6305][FOLLOWUP] Improve package Spark SQL engine both Scala 2.12 and 2.13

[PorterZhang2021]

🔍 Description

Issue References 🔗

This pull request fixes #6305

Describe Your Solution 🔧

Solution 1 use <profile> - Inappropriate

I found a way to use , roughly as follows:

<profile>
    <id>scala-2.12</id>
    <properties>
        <scala.binary.version>2.12</scala.binary.version>
    </properties>
</profile>

After specifying, I attempted to use

1. build/mvn install -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true - Dmaven.source.skip -Pscala-2.12 -Pscala-2.13 -pl: kyuubi-spark-sql-engine -am
2. build/mvn install -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true - Dmaven.source.skip -Pscala-2.13 -Pscala-2.12 -pl: kyuubi-spark-sql-engine -am

Problem

But in the end, it was found that if both '-Pscala-2.12' and '-Pscala-2.13' are used at the same time, '-Pscala2.13' will be selected by default, which may not be a good solution to this problem.

Solution2

Later, I thought about whether it was possible to filter the parameter '$@' internally. It is effective.

Types of changes 🔖

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

1. scala2.12
   
   
2. scala2.13
   
   

---

Checklist 📝

• This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

[yikf]

Suggested change

	EXTRA_SPARK_ENGINE_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT -pl ${FILTERED_ARGS[@]} :kyuubi-spark-sql-engine_2.12 -am)
	EXTRA_SPARK_ENGINE_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT ${FILTERED_ARGS[@]} -pl :kyuubi-spark-sql-engine_2.12 -am)

[yikf]

I agree with the approach of dealing with parameters If there's no better way, even if it is hack to compare.

Not only are we dealing with arguments like -Pscala*, but we also need -P p1,scala-2.13, -P p1,scala-2.13,p2... -Dscala.version=2.13 and so on.

In addition, we can add some comments to describe it, and if the scala version changes in the future, it can guide the developer to clarify the meaning of this piece and determine whether it needs to change.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.49%. Comparing base (28d8c8e) to head (5524b13).
Report is 16 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6330      +/-   ##
============================================
+ Coverage     58.41%   58.49%   +0.07%     
  Complexity       24       24              
============================================
  Files           653      653              
  Lines         39880    39968      +88     
  Branches       5481     5488       +7     
============================================
+ Hits          23296    23378      +82     
- Misses        14083    14091       +8     
+ Partials       2501     2499       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[PorterZhang2021]

Hello , I have revised the filtering according to @yikf 's suggestion, but it is not easy to solve the problem of - p scala-2.13 p1. Therefore, I have written a simple prompt for users to use the - pscala-2.13,p1 method, cc @yikf @pan3793

[pan3793]

@PorterZhang2021 thanks for keeping work on this issue. actually, we can replace all mvn args scala-2.12 with scala-2.13 and vice versa

[pan3793]

BTW, the code you pasted is weird, like something produced by OCR?

[PorterZhang2021]

@PorterZhang2021 thanks for keeping work on this issue. actually, we can replace all mvn args scala-2.12 with scala-2.13 and vice versa

ok, I will try it again, I'm not quite sure what ocr means. Perhaps there is a part of the content that I searched for Google and inquired about GPT, and then made similar implementations myself, which looks a bit strange. I will make some modifications later.

[pan3793]

OCR means "Optical Character Recognition", what I mean strange part is

[PorterZhang2021]

cc @pan3793

[pan3793]

Verified locally.

[pan3793]

Thanks, merged to master

[pan3793]

Cherry-picked to 1.9.1 to support Spark 4.0.0-preview1