Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6326] Load existing pods and services when initializing the k8s client #6327

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Apr 19, 2024

🔍 Description

Issue References 🔗

Close #6326
Seems that the informer will ignore the existing resources if no add/update/deletion.

It is better to load it one time when initializing the server.

We also audit the engine service in this pr.

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@turboFei turboFei changed the title load [KYUUBI #6326] Load existing pods and services when initializing the service Apr 19, 2024
@turboFei turboFei changed the title [KYUUBI #6326] Load existing pods and services when initializing the service [KYUUBI #6326] Load existing pods and services when initializing the k8s client Apr 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 58.42%. Comparing base (90491fc) to head (a8b5f8f).
Report is 2 commits behind head on master.

Files Patch % Lines
...kyuubi/engine/KubernetesApplicationOperation.scala 0.00% 23 Missing ⚠️
...uubi/engine/KubernetesApplicationAuditLogger.scala 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6327      +/-   ##
============================================
- Coverage     58.45%   58.42%   -0.03%     
  Complexity       24       24              
============================================
  Files           653      653              
  Lines         39834    39854      +20     
  Branches       5477     5474       -3     
============================================
+ Hits          23283    23285       +2     
- Misses        14064    14079      +15     
- Partials       2487     2490       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turboFei turboFei self-assigned this Apr 22, 2024
Copy link
Contributor

@zwangsheng zwangsheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine. I'm worried about whether we're hitting Api Server in a special case with this once load operation. WDYT @pan3793

@turboFei
Copy link
Member Author

turboFei commented May 8, 2024

any comments? @pan3793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Load the pods/services when initializing kyuubi service
3 participants