Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6084] JDBC driver supports configuration not to pull engine startup logs #6106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lsm1
Copy link
Contributor

@lsm1 lsm1 commented Feb 28, 2024

🔍 Description

Issue References 🔗

This pull request fixes #6084

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Support --ignore-launch-engine option and not pull engine starup logs

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@pan3793 pan3793 changed the title [KYUUBI #6084][Improvement] JDBC driver supports configuration not to pull engine startup logs #6084 [KYUUBI #6084] JDBC driver supports configuration not to pull engine startup logs Feb 28, 2024
@pan3793
Copy link
Member

pan3793 commented Feb 28, 2024

is it for security purposes? if so, maybe we should disable the log on the server side?

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.25%. Comparing base (2c9fb3d) to head (a9c08ad).
Report is 35 commits behind head on master.

Files Patch % Lines
.../org/apache/kyuubi/jdbc/hive/KyuubiConnection.java 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6106      +/-   ##
============================================
+ Coverage     61.12%   62.25%   +1.13%     
- Complexity       23       24       +1     
============================================
  Files           623      625       +2     
  Lines         37200    38982    +1782     
  Branches       5040     5333     +293     
============================================
+ Hits          22738    24269    +1531     
- Misses        12001    12245     +244     
- Partials       2461     2468       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cxzl25
Copy link
Contributor

cxzl25 commented Feb 28, 2024

is it for security purposes?

We just want to align hive's native beeline behavior and reduce some logs and RPC.

@pan3793
Copy link
Member

pan3793 commented Feb 28, 2024

beeline has a --verbose option, seems we do not respect it though

@zhouyifan279
Copy link
Contributor

Can we skip the creation of engine-launch-log thread created byKyuubiConnection#showLaunchEngineLog if ignoreLaunchEngineLog is true ?

@cxzl25 cxzl25 added this to the v1.9.0 milestone Mar 11, 2024
@pan3793 pan3793 modified the milestones: v1.9.0, v1.9.1 Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] JDBC driver supports configuration not to pull engine startup logs
5 participants