New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #6326] Load existing pods and services when initializing the k8s client #6327
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6327 +/- ##
============================================
- Coverage 58.45% 58.42% -0.03%
Complexity 24 24
============================================
Files 653 653
Lines 39834 39854 +20
Branches 5477 5474 -3
============================================
+ Hits 23283 23285 +2
- Misses 14064 14079 +15
- Partials 2487 2490 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly fine. I'm worried about whether we're hitting Api Server in a special case with this once load operation. WDYT @pan3793
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationAuditLogger.scala
Show resolved
Hide resolved
any comments? @pan3793 |
🔍 Description
Issue References 🔗
Close #6326
Seems that the informer will ignore the existing resources if no add/update/deletion.
It is better to load it one time when initializing the server.
We also audit the engine service in this pr.
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.