Improve code example for using a transactional KafkaProducer #15901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a short discussion with Sophie Blee-Goldman (see https://lists.apache.org/thread/x4szs4szq0gq1twrpdv0fppzr92rr623), I dived into a few days of debugging and testing with a network connection that can deliberately switched to drop all packages. As I also work with Spring sometimes, I finally looked up how Spring Kafka does the exception handling and came up with quite a simple solution that at least works very well with my test scenarios: I used all the default timeouts for the configuration of the producer and tested with network outages (packages are dropped) of 20 seconds, 45 seconds and 75 seconds.
While transforming my production code back into a code sample, I changed it from catching general Exceptions to catching KafkaExceptions, because Sophie mentioned she doesn't like general Exceptions to be caught.
Please consider this PR as a request for comments, as I am rather new to Kafka and I didn't quite understand all the details of the original code sample.