OAK-9989: introduce wrapped-guava and use it in oak-commons #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reschke
requested review from
amit-jain,
thomasmueller,
anchela,
mreutegg and
stefan-egli
and removed request for
amit-jain
rishabhdaim
reviewed
Mar 27, 2023
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/FileIOUtils.java
Show resolved
Hide resolved
rishabhdaim
reviewed
Mar 27, 2023
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/io/LazyInputStream.java
Show resolved
Hide resolved
rishabhdaim
reviewed
Mar 27, 2023
oak-commons/src/test/java/org/apache/jackrabbit/oak/commons/FileIOUtilsTest.java
Show resolved
Hide resolved
rishabhdaim
reviewed
Mar 27, 2023
mreutegg
requested changes
Mar 27, 2023
|
@rishabhdaim - thanks for the review. The leftovers in oak-commons are intentional; that is a module that currently has Guava APIs in it's public interfaces. These are deprecated and will be removed in a separate step. (I picked that module for the proof of concept exactly because of the additional complexitiy in this module). |
mreutegg
approved these changes
Mar 27, 2023
rishabhdaim
approved these changes
Mar 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.