Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-10141: relevance on queries involving dynamic boost sometimes differ from lucene #872

Merged
merged 7 commits into from
Mar 24, 2023

Conversation

fabriziofortino
Copy link
Contributor

  • refactoring of full-text tests to share them between lucene and elastic
  • fix an issue on elastic where full-text queries wrongly assigned the boost factor on specific fields
  • fix relevance in Elastic when dynamic boost is enabled. The dynamic terms need to be de-boosted (as it happens in lucene). To properly address the issue, a new field has been created. This is not a breaking change since the queries won't complain in case the field is not yet there. A reindex is required to get the correct relevant results.

Copy link
Contributor

@nit0906 nit0906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - If possible, can we check that we didn't miss any test during the refactoring ?

Maybe just compare the list of tests from a build on trunk vs this ?

@fabriziofortino
Copy link
Contributor Author

@nit0906 the list of tests is not the same as before. While refactoring, I noticed duplicate tests that I removed and added new tests. To easily see what was done in the refactoring, you can have a look at the specific commits in this PR. Every commit has a clear description and you can see the relevant changes in smaller chunks.

@fabriziofortino fabriziofortino merged commit eca09a0 into apache:trunk Mar 24, 2023
@fabriziofortino fabriziofortino deleted the OAK-10141 branch March 24, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants