Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Splitting dependencies for common, client, and server #6398

Open
wants to merge 55 commits into
base: 2.x
Choose a base branch
from

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Mar 8, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

1.1) Change log:

  1. optimize: Splitting dependencies for common, client, and server, and simplify the dependency of the modules server, console, and test-mock-server
    优化:拆分通用、客户端、服务端的依赖,并简化server、console、mock-server的依赖配置。
  2. 调整依赖关系,通过parent的方式引用 dependencies* 中定义的依赖。
  3. bugfix: 修复一个测试用例在macos环境中执行失败的问题;
  4. 解决部分希望固定版本号的依赖但在server相关模块下,却被spring-boot-dependencies:2.7.18中的引入的版本号给覆盖了的问题。
  5. upgrade github actions: actions/checkout@v4.1.1actions/setup-java@v4.1.0, the warnning from actions page:
    图片
  6. 优化部分单元测试,提升成功率。
  7. 添加一些日志信息。

1.2) See the logs of the workflows: test.yml, test-druid.yml

https://github.com/wangliang181230/seata/actions?query=branch%3Atest-dependency-structure

1.3) Design:

311632024-b024cb95-fca3-4b5a-af50-0d0e20f5f881

  1. common modules:
    • common
    • core
    • compressor/*
    • config/*
    • discovery/*
    • serializer/*
    • seata-spring-autoconfigure-core
  2. client modules:
    • integration-tx-api
    • integration/*
    • rm-datasource
    • rm
    • rocketmq
    • saga
    • seata-plugin/*
    • seata-spring-autoconfigure-client
    • seata-spring-boot-starter
    • sqlparser
    • tcc
    • tm
    • test
    • all
  3. server modules:
    • console
    • server
    • test-mock-server
    • distribution
    • ext/apm-seata-skywalking-plugin
    • metrics/*
    • seata-spring-autoconfigure-server

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 50.36%. Comparing base (d318409) to head (8261052).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6398      +/-   ##
============================================
- Coverage     50.81%   50.36%   -0.45%     
+ Complexity     5285     5243      -42     
============================================
  Files           942      942              
  Lines         33270    33275       +5     
  Branches       4030     4031       +1     
============================================
- Hits          16907    16760     -147     
- Misses        14698    14893     +195     
+ Partials       1665     1622      -43     
Files Coverage Δ
...org/apache/seata/config/AbstractConfiguration.java 69.44% <100.00%> (+3.81%) ⬆️
.../org/apache/seata/config/ConfigurationFactory.java 58.75% <0.00%> (-1.25%) ⬇️
...g/plugin/DefaultCoreDoGlobalCommitInterceptor.java 0.00% <0.00%> (ø)
...plugin/NettyRemotingClientSendSyncInterceptor.java 0.00% <0.00%> (ø)
...ng/plugin/RemotingProcessorProcessInterceptor.java 0.00% <0.00%> (ø)
...che/seata/core/rpc/netty/NettyServerBootstrap.java 48.95% <50.00%> (-12.16%) ⬇️

... and 28 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants