Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: the problem that the number of mirrors before and after may be inconsistent #6348

Open
wants to merge 8 commits into
base: 2.x
Choose a base branch
from

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Feb 18, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

1.update count大于 before size时,抛出异常阻断
2.当update的where条件中没有主键时,后镜像采用前镜像方式制作,且进行对比前后镜像查询的行数结果

Ⅱ. Does this pull request fix one issue?

fixes #4727

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 17.80822% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 52.26%. Comparing base (d47a5d5) to head (b168cdc).

❗ Current head b168cdc differs from pull request most recent head ad6999d. Consider uploading reports for the commit ad6999d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6348      +/-   ##
============================================
+ Coverage     50.38%   52.26%   +1.87%     
+ Complexity     5250     5215      -35     
============================================
  Files           942      920      -22     
  Lines         33289    32008    -1281     
  Branches       4037     3829     -208     
============================================
- Hits          16773    16729      -44     
+ Misses        14891    13633    -1258     
- Partials       1625     1646      +21     
Files Coverage Δ
...pache/seata/rm/datasource/exec/UpdateExecutor.java 85.71% <100.00%> (+1.62%) ⬆️
...e/seata/sqlparser/druid/dm/DmUpdateRecognizer.java 0.00% <0.00%> (ø)
...a/sqlparser/druid/mysql/MySQLUpdateRecognizer.java 61.00% <0.00%> (-1.25%) ⬇️
...sqlparser/druid/oracle/OracleUpdateRecognizer.java 7.01% <0.00%> (-0.26%) ⬇️
...r/druid/postgresql/PostgresqlUpdateRecognizer.java 7.01% <0.00%> (-0.26%) ⬇️
...ser/druid/sqlserver/SqlServerUpdateRecognizer.java 70.83% <0.00%> (-2.03%) ⬇️
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 48.33% <16.66%> (-3.52%) ⬇️
...parser/antlr/mysql/AntlrMySQLUpdateRecognizer.java 0.00% <0.00%> (ø)
...g/apache/seata/sqlparser/druid/BaseRecognizer.java 45.33% <0.00%> (-35.62%) ⬇️

... and 86 files with indirect coverage changes

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module module/sqlparser sql-parser module labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module module/sqlparser sql-parser module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AT模式在oracle和postgresql中回滚逻辑实现不正确。
3 participants