optimize : Eliminate RpcMessage and Encoder/Decoder dependencies #6209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Bughue
changed the title
funky-eyes
reviewed
Dec 27, 2023
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6209 +/- ##
============================================
+ Coverage 50.19% 50.28% +0.08%
- Complexity 5232 5253 +21
============================================
Files 942 944 +2
Lines 33221 33382 +161
Branches 4022 4042 +20
============================================
+ Hits 16676 16786 +110
- Misses 14938 14969 +31
- Partials 1607 1627 +20
|
…-msg # Conflicts: # core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemoting.java # core/src/main/java/org/apache/seata/core/rpc/netty/ProtocolRpcMessage.java # core/src/main/java/org/apache/seata/core/rpc/netty/v0/ProtocolRpcMessageV0.java # core/src/main/java/org/apache/seata/core/rpc/netty/v1/ProtocolRpcMessageV1.java # core/src/main/java/org/apache/seata/core/rpc/netty/v1/ProtocolV1Decoder.java # test/src/test/java/org/apache/seata/core/rpc/netty/v1/ClientChannelHandler.java # test/src/test/java/org/apache/seata/core/rpc/netty/v1/ProtocolV1SerializerTest.java # test/src/test/java/org/apache/seata/core/rpc/netty/v1/ServerChannelHandler.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
新引入ProtocolRpcMessage（接口），用以解开rpcmessage和encoder/decoder的依赖关系。encoder/decoder只依赖ProtocolRpcMessage（支持不同版本协议的区分），而原有的RpcMessage继续服务于协议解析后的业务逻辑
A new ProtocolRpcMessage interface is introduced to decouple rpcmessage from encoder/decoder, which only relies on ProtocolRpcMessage (to support differentiation between different versions of the protocol), while the original RpcMessage continues to serve the The original RpcMessage continues to serve the business logic after the protocol is parsed.
Ⅱ. Does this pull request fix one issue?
fixes #6210
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews