optimize : load SeataSerializer by version #6208

Bughue · 2023-12-25T10:25:19Z

I have registered the PR changes.

Ⅰ. Describe what this PR did

load SeataSerializer by version

Ⅱ. Does this pull request fix one issue?

fixes #6211

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

core/src/main/java/io/seata/core/serializer/SerializerServiceLoader.java

serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/SeataSerializer.java

core/src/main/java/io/seata/core/serializer/SerializerServiceLoader.java

serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/SeataSerializer.java

...ializer-seata/src/main/java/io/seata/serializer/seata/protocol/v0/MessageCodecFactoryV0.java

serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/SeataSerializer.java

...rializer-seata/src/main/java/io/seata/serializer/seata/protocol/MergeResultMessageCodec.java

core/src/main/java/io/seata/core/rpc/netty/v1/ProtocolV1Encoder.java

codecov-commenter · 2024-01-02T03:18:44Z

Codecov Report

Attention: Patch coverage is 56.66667% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 52.38%. Comparing base (e72babb) to head (704669a).
Report is 11 commits behind head on 2.x.

❗ Current head 704669a differs from pull request most recent head 3cc6ca3. Consider uploading reports for the commit 3cc6ca3 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #6208      +/-   ##
============================================
+ Coverage     50.19%   52.38%   +2.19%     
- Complexity     5232     5245      +13     
============================================
  Files           942      924      -18     
  Lines         33221    32119    -1102     
  Branches       4022     3842     -180     
============================================
+ Hits          16676    16827     +151     
+ Misses        14938    13628    -1310     
- Partials       1607     1664      +57

Files	Coverage Δ
.../apache/seata/core/protocol/ProtocolConstants.java	`100.00% <ø> (+100.00%)`	⬆️
...alizer/seata/protocol/BatchResultMessageCodec.java	`85.45% <100.00%> (+0.54%)`	⬆️
...alizer/seata/protocol/MergeResultMessageCodec.java	`80.48% <100.00%> (+1.00%)`	⬆️
...ializer/seata/protocol/MergedWarpMessageCodec.java	`83.92% <100.00%> (+0.59%)`	⬆️
...che/seata/core/rpc/netty/v1/ProtocolV1Decoder.java	`65.45% <0.00%> (+50.90%)`	⬆️
...che/seata/core/rpc/netty/v1/ProtocolV1Encoder.java	`66.66% <0.00%> (+61.53%)`	⬆️
...he/seata/serializer/seata/MessageCodecFactory.java	`83.18% <83.33%> (ø)`
...seata/core/serializer/SerializerServiceLoader.java	`23.52% <33.33%> (+23.52%)`	⬆️
...apache/seata/serializer/seata/SeataSerializer.java	`51.51% <49.09%> (-28.49%)`	⬇️

... and 98 files with indirect coverage changes

...-serializer-seata/src/main/java/io/seata/serializer/seata/protocol/v0/SeataSerializerV0.java

serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/SeataSerializer.java

…ialize-version # Conflicts: # core/src/main/java/io/seata/core/rpc/netty/v1/ProtocolV1Decoder.java

…ialize-version # Conflicts: # serializer/seata-serializer-seata/src/main/java/org/apache/seata/serializer/seata/SeataSerializer.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/BatchResultMessageSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/MergeResultMessageSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/MergedWarpMessageSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/RegisterRMRequestSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/RegisterRMResponseSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/RegisterTMRequestSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/RegisterTMResponseSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/BranchCommitRequestSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/BranchCommitResponseSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/BranchRegisterRequestSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/BranchRegisterResponseSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/BranchReportRequestSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/BranchReportResponseSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/BranchRollbackRequestSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/BranchRollbackResponseSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/GlobalBeginRequestSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/GlobalBeginResponseSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/GlobalCommitRequestCodecTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/GlobalCommitResponseSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/GlobalLockQueryRequestSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/GlobalLockQueryResponseSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/GlobalRollbackRequestCodecTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/GlobalRollbackResponseSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/GlobalStatusRequestCodecTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/GlobalStatusResponseSerializerTest.java # serializer/seata-serializer-seata/src/test/java/org/apache/seata/serializer/seata/protocol/transaction/UndoLogDeleteRequestSerializerTest.java

…ialize-version # Conflicts: # core/src/main/java/org/apache/seata/core/rpc/netty/v1/ProtocolV1Decoder.java # core/src/main/java/org/apache/seata/core/serializer/SerializerServiceLoader.java

.../seata-serializer-seata/src/main/java/org/apache/seata/serializer/seata/SeataSerializer.java

funky-eyes

LGTM

load SeataSerializer by version

39d88c1

Bughue mentioned this pull request Dec 25, 2023

feature : multi-version protocol control #5738

Closed

1 task

Bughue added 3 commits December 26, 2023 14:49

license

901b886

style

b518004

test ProtocolConstants.VERSION

883adfb

funky-eyes requested a review from wangliang181230 December 27, 2023 03:00

funky-eyes added this to the 2.1.0 milestone Dec 27, 2023

funky-eyes added the module/common common module label Dec 27, 2023

funky-eyes reviewed Dec 27, 2023

View reviewed changes

core/src/main/java/io/seata/core/serializer/SerializerServiceLoader.java Outdated Show resolved Hide resolved

serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/SeataSerializer.java Outdated Show resolved Hide resolved

Bughue changed the title ~~feature : load SeataSerializer by version~~ optimize : load SeataSerializer by version Dec 27, 2023

version serialize

492672c

wangliang181230 reviewed Dec 28, 2023

View reviewed changes

core/src/main/java/io/seata/core/serializer/SerializerServiceLoader.java Outdated Show resolved Hide resolved

wangliang181230 reviewed Dec 28, 2023

View reviewed changes

serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/SeataSerializer.java Outdated Show resolved Hide resolved

wangliang181230 reviewed Dec 28, 2023

View reviewed changes

...ializer-seata/src/main/java/io/seata/serializer/seata/protocol/v0/MessageCodecFactoryV0.java Outdated Show resolved Hide resolved

wangliang181230 reviewed Dec 28, 2023

View reviewed changes

...ializer-seata/src/main/java/io/seata/serializer/seata/protocol/v0/MessageCodecFactoryV0.java Outdated Show resolved Hide resolved

Bughue mentioned this pull request Dec 29, 2023

[WIP]optimize : multi-version protocol support #6226

Open

1 task

Bughue added 6 commits December 29, 2023 10:55

v0

d8c19a4

v0

958ef77

v0

2a0d836

v0

227464b

license

0afa845

license

4959cbe

funky-eyes reviewed Dec 29, 2023

View reviewed changes

Bughue added 2 commits December 29, 2023 17:20

style

dfd9bf2

style

48a6090

funky-eyes reviewed Jan 3, 2024

View reviewed changes

...-serializer-seata/src/main/java/io/seata/serializer/seata/protocol/v0/SeataSerializerV0.java Outdated Show resolved Hide resolved

Bughue added 2 commits January 4, 2024 14:51

inner class

181a421

inner class

d2804fb

funky-eyes reviewed Jan 5, 2024

View reviewed changes

serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/SeataSerializer.java Outdated Show resolved Hide resolved

serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/SeataSerializer.java Outdated Show resolved Hide resolved

funky-eyes reviewed Jan 12, 2024

View reviewed changes

serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/SeataSerializer.java Outdated Show resolved Hide resolved

Bughue added 6 commits January 22, 2024 18:13

single pattern

342d306

Merge branch '2.x' of https://github.com/seata/seata into dev-mlv-ser…

439d132

…ialize-version # Conflicts: # core/src/main/java/io/seata/core/rpc/netty/v1/ProtocolV1Decoder.java

conflit

74c48d5

resolve conflict

0f8c187

style

704669a

funky-eyes removed this from the 2.1.0 milestone Mar 2, 2024

Bughue added 2 commits April 30, 2024 09:58

Merge branch '2.x' of https://github.com/seata/seata into dev-mlv-ser…

9d30454

…ialize-version # Conflicts: # core/src/main/java/org/apache/seata/core/rpc/netty/v1/ProtocolV1Decoder.java # core/src/main/java/org/apache/seata/core/serializer/SerializerServiceLoader.java

merge

2f5feb0

funky-eyes added this to the 2.2.0 milestone May 6, 2024

funky-eyes added module/core core module module/serializer serializer module and removed module/common common module labels May 7, 2024

funky-eyes reviewed May 7, 2024

View reviewed changes

.../seata-serializer-seata/src/main/java/org/apache/seata/serializer/seata/SeataSerializer.java Outdated Show resolved Hide resolved

.../seata-serializer-seata/src/main/java/org/apache/seata/serializer/seata/SeataSerializer.java Outdated Show resolved Hide resolved

Bughue added 3 commits May 7, 2024 14:21

double lock check

89c0674

double lock check

b649852

double lock check

3cc6ca3

funky-eyes approved these changes May 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

optimize : load SeataSerializer by version #6208

optimize : load SeataSerializer by version #6208

Bughue commented Dec 25, 2023 •

edited

codecov-commenter commented Jan 2, 2024 •

edited

funky-eyes left a comment

optimize : load SeataSerializer by version #6208

Are you sure you want to change the base?

optimize : load SeataSerializer by version #6208

Conversation

Bughue commented Dec 25, 2023 • edited

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-commenter commented Jan 2, 2024 • edited

Codecov Report

funky-eyes left a comment

Choose a reason for hiding this comment

Bughue commented Dec 25, 2023 •

edited

codecov-commenter commented Jan 2, 2024 •

edited