optimize: zk push empty protect #6206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Dec 25, 2023
| * @param clusterName cluserName | ||
| */ | ||
| private boolean isCurrentCluster(String clusterName) { | ||
| String txServiceGroupName = ConfigurationFactory.getInstance() |
There was a problem hiding this comment.
如果使用的是seata-all，这个配置很有可能读不到，比如以下写法：
If you are using seata-all, this configuration is likely to be unreadable, such as the following:
new GlobalTransactionScanner("test", "group_a", failureHandler);
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6206 +/- ##
============================================
+ Coverage 48.98% 49.02% +0.04%
- Complexity 4779 4785 +6
============================================
Files 915 915
Lines 31896 31909 +13
Branches 3855 3856 +1
============================================
+ Hits 15624 15644 +20
+ Misses 14710 14705 -5
+ Partials 1562 1560 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
#6162
Ⅱ. Does this pull request fix one issue?
fixes #6162
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews