Test: increase spring autoconfigure module unit test coverage #6198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6198 +/- ##
============================================
+ Coverage 51.07% 52.70% +1.62%
- Complexity 5097 5419 +322
============================================
Files 918 918
Lines 32031 32031
Branches 3865 3865
============================================
+ Hits 16361 16882 +521
+ Misses 14097 13582 -515
+ Partials 1573 1567 -6 |
l81893521
force-pushed
the
test_incr_spring_autoconfigure_unit_test
branch
from
3ea9016
to
380c374
Compare
l81893521
changed the title
lightClouds917
suggested changes
Jan 10, 2024
...rc/test/java/io/seata/spring/boot/autoconfigure/SeataClientEnvironmentPostProcessorTest.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Jan 15, 2024
...-client/src/test/java/io/seata/spring/boot/autoconfigure/properties/SeataPropertiesTest.java
Outdated
Show resolved
Hide resolved
l81893521
force-pushed
the
test_incr_spring_autoconfigure_unit_test
branch
from
4b8e119
to
18e3b50
Compare
funky-eyes
reviewed
Jan 18, 2024
There was a problem hiding this comment.
*PropertiesTest 我希望这些properties的get set的相关方法通过扫描包，解析类，进行反射将其中的method一次性处理掉，至于入参类型可以通过反射拿到参数类型，写一个switch等方式来处理。
*PropertiesTest I want the get set related methods of these properties to scan the package, parse the class, and do reflection to get rid of the method once and for all, and as for the input parameter type can be dealt with by getting the parameter type through reflection, writing a switch, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6199
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews