Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the column TINYINT(1) in MySql being resolved to BIT type #6070

Open
wants to merge 17 commits into
base: 2.x
Choose a base branch
from

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Nov 21, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

bugfix: fix the column TINYINT(1) in MySql being resolved to BIT type.
修复 “MySql中的 TINYINT(1) 类型字段被解析为BIT,导致回滚后的值要么是0,要么是1。而不是原来的值。” 的问题。

Ⅱ. Does this pull request fix one issue?

fixes #6064
fixes #4006
fixes #1964

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #6070 (b7907e8) into 2.x (f42fb72) will increase coverage by 0.00%.
The diff coverage is 54.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6070   +/-   ##
=========================================
  Coverage     49.29%   49.29%           
- Complexity     4800     4803    +3     
=========================================
  Files           913      915    +2     
  Lines         31677    31727   +50     
  Branches       3825     3831    +6     
=========================================
+ Hits          15614    15641   +27     
- Misses        14514    14532   +18     
- Partials       1549     1554    +5     
Files Coverage Δ
...main/java/io/seata/common/util/ReflectionUtil.java 73.11% <100.00%> (+0.59%) ⬆️
...seata/core/context/FastThreadLocalContextCore.java 85.71% <ø> (ø)
.../datasource/sql/struct/cache/DmTableMetaCache.java 83.14% <100.00%> (ø)
...source/sql/struct/cache/MariadbTableMetaCache.java 77.77% <100.00%> (ø)
...asource/sql/struct/cache/OracleTableMetaCache.java 67.30% <100.00%> (ø)
...rce/sql/struct/cache/PostgresqlTableMetaCache.java 74.72% <100.00%> (ø)
...urce/sql/struct/cache/SqlServerTableMetaCache.java 79.20% <100.00%> (ø)
...ource/sql/struct/cache/PolarDBXTableMetaCache.java 11.11% <0.00%> (ø)
...seata/rm/datasource/undo/AbstractUndoExecutor.java 69.86% <80.00%> (+0.41%) ⬆️
...in/java/io/seata/sqlparser/util/JdbcConstants.java 0.00% <0.00%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license issue

@slievrly slievrly added the Do Not Merge Do not merge into develop label Nov 21, 2023
@funky-eyes funky-eyes added the module/rm-datasource rm-datasource module label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Do not merge into develop module/rm-datasource rm-datasource module
Projects
None yet
3 participants