feature: support openGuass and GuassDB in AT mode #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuqiufeng
changed the title
funky-eyes
added
type: feature
liuqiufeng
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6020 +/- ##
============================================
- Coverage 49.45% 49.30% -0.15%
+ Complexity 4811 4795 -16
============================================
Files 913 928 +15
Lines 31678 31735 +57
Branches 3826 3838 +12
============================================
- Hits 15665 15648 -17
- Misses 14474 14546 +72
- Partials 1539 1541 +2
|
funky-eyes
reviewed
Dec 1, 2023
slievrly
reviewed
Dec 6, 2023
| @@ -221,6 +222,11 @@ | |||
| <artifactId>DmJdbcDriver18</artifactId> | |||
| <version>${dm.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.opengauss</groupId> | |||
| <artifactId>opengauss-jdbc</artifactId> | |||
There was a problem hiding this comment.
check license as `BSD 2-clause’
slievrly
reviewed
Dec 6, 2023
| <!-- db connection pool --> | ||
| <druid.version>1.2.7</druid.version> | ||
| <druid.version>1.2.12</druid.version> |
There was a problem hiding this comment.
why upgrade the druid version, Is there any compatibility issue between this database and Druid?
There was a problem hiding this comment.
Druid 1.2.12 is the lowest supported version of openGauss
slievrly
reviewed
Dec 6, 2023
| <!-- db connection pool --> | ||
| <druid.version>1.2.7</druid.version> | ||
| <druid.version>1.2.12</druid.version> |
There was a problem hiding this comment.
why upgrade the druid version, Is there any compatibility issue between this database and Druid?
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6020 +/- ##
============================================
+ Coverage 48.98% 49.64% +0.66%
- Complexity 4779 4895 +116
============================================
Files 915 930 +15
Lines 31896 31946 +50
Branches 3855 3856 +1
============================================
+ Hits 15624 15860 +236
+ Misses 14710 14526 -184
+ Partials 1562 1560 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support openGuass and GuassDB
支持openGuass 和 GuassDB
Ⅱ. Does this pull request fix one issue?
fixes #5740
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews