IGNITE-21830 Fixed logging of failed attempts to connect to the previous node in the ring. #11327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 24, 2024 16:51
* New logs for socket connection check * Integration tests
* clean-up, checkstyle
* clean-up, license
Vladsz83
reviewed
Apr 25, 2024
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
Outdated
Show resolved
Hide resolved
added 4 commits
April 26, 2024 11:51
* redundant logging removed * tests corrected
* ignored connection logs removed
* Added nodeId to logs * Adjusted tests
* test suit error fixed
Vladsz83
reviewed
May 2, 2024
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 2, 2024
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 2, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
May 3, 2024 17:27
* Warning added for failures * logs builder
* clean-up
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 6, 2024
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiLogTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
May 7, 2024 12:21
* log refactor * tests clean-up
* tests clean-up
Vladsz83
reviewed
May 9, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Outdated
Show resolved
Hide resolved
* Square brackets corrected * Tests refactored
Vladsz83
reviewed
May 13, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Outdated
Show resolved
Hide resolved
* Square brackets corrected * Tests refactored
Vladsz83
reviewed
May 13, 2024
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 13, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Show resolved
Hide resolved
Vladsz83
reviewed
May 13, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 13, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 13, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 13, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 13, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 13, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 13, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 13, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Outdated
Show resolved
Hide resolved
* log corrected * tests refactored
Vladsz83
reviewed
May 14, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Outdated
Show resolved
Hide resolved
Vladsz83
reviewed
May 14, 2024
...es/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryNetworkIssuesTest.java
Outdated
Show resolved
Hide resolved
added 9 commits
May 14, 2024 15:54
* tests refactored
* tests refactored * redundant logs removed
* result log corrected
* Code style fix
* Log optimizations
* logs refactored
* clean-up
* test refactored
* Code style fix
petrov-mg
approved these changes
May 21, 2024
petrov-mg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit body:
Summary: Connection summary log implemented for failed attempts of previous node check with error message. This summary is usefull for aftermath analysis of topology changes, e.g. due to
NODE_FAILEDevents. It sheds the light on decision-making process for choosing the alive addressThank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.