#10275 - fix NullPointerException #10284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix NullPointerException when trying to add the vector's class name to the message for an UnsupportedOperationException
nastra
reviewed
May 8, 2024
nastra
reviewed
May 8, 2024
...src/test/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactoryTest.java
Outdated
Show resolved
Hide resolved
|
I think it would be good to add a test that reproduces the issue you described in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NullPointerException when trying to add the vector's class name to the message for an UnsupportedOperationException.
This PR will handle the case where
valueis null. This fixes the NullPointerException I reported in issue #10275. Still, I suspect there is a larger issue at play. I suspect there is supposed to be some kind of ArrowVectorAccessor class for accessing null values.Please see the bug report #10275 for additional context and details