Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-7704] Unify test client storage classes with duplicate code #11152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wombatu-kun
Copy link
Contributor

@wombatu-kun wombatu-kun commented May 5, 2024

Change Logs

TestHoodieClientOnCopyOnWriteStorage and TestHoodieJavaClientOnCopyOnWriteStorage have a bunch of duplicate code, so i:

  • extracted common code (with some parameterizations) to HoodieWriterClientTestHarness class;
  • removed unused code;
  • moved static assertions-methods to existing separate class Assertions.

I did not add, remove or change subject of any test, I've just refactored these classes to avoid code duplications.

Impact

none

Risk level (write none, low medium or high below)

none

Documentation Update

none

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:L PR with lines of changes in (300, 1000] label May 5, 2024
@wombatu-kun wombatu-kun force-pushed the HUDI-7704_unify_test_client_storage_classes branch 5 times, most recently from 5168a19 to f48519d Compare May 6, 2024 08:21
@github-actions github-actions bot added size:XL PR with lines of changes > 1000 and removed size:L PR with lines of changes in (300, 1000] labels May 6, 2024
@wombatu-kun wombatu-kun force-pushed the HUDI-7704_unify_test_client_storage_classes branch 21 times, most recently from c5add8c to 0b6a222 Compare May 11, 2024 12:41
@wombatu-kun wombatu-kun marked this pull request as ready for review May 11, 2024 12:48
@danny0405
Copy link
Contributor

cc @the-other-tim-brown for the code reviewing.

@wombatu-kun wombatu-kun force-pushed the HUDI-7704_unify_test_client_storage_classes branch from 0b6a222 to c468c73 Compare May 15, 2024 04:39
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL PR with lines of changes > 1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants