[HUDI-7707] Enable bundle validation on Java 8 and 11 #11142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
force-pushed
the
HUDI-7707-ci-java8-11
branch
3 times, most recently
from
14896f2
to
fd5383c
Compare
github-actions
bot
added
size:S
bvaradar
approved these changes
May 3, 2024
yihua
force-pushed
the
HUDI-7707-ci-java8-11
branch
from
fd5383c
to
7bb8334
Compare
yihua
changed the title
yihua
force-pushed
the
HUDI-7707-ci-java8-11
branch
2 times, most recently
from
2efc518
to
e7a53af
Compare
yihua
force-pushed
the
HUDI-7707-ci-java8-11
branch
from
e7a53af
to
61e81b9
Compare
|
Bundle validation runs on Java 8 and 11 again. |
yihua
changed the title
|
All bundle validations pass. Merging the PR. |
4 tasks
yihua
commented
May 27, 2024
| @@ -299,7 +299,7 @@ if [ "$?" -ne 0 ]; then | |||
| fi | |||
| echo "::warning::validate.sh done validating utilities slim bundle" | |||
|
|
|||
| if [[ ${JAVA_RUNTIME_VERSION} == 'openjdk8' && ${SCALA_PROFILE} != 'scala-2.13' ]]; then | |||
| if [[ ${JAVA_RUNTIME_VERSION} == 'openjdk8' && ${SCALA_PROFILE} != 'scala-2.13' && ! "${FLINK_HOME}" == *"1.18"* ]]; then | |||
There was a problem hiding this comment.
Flink 1.18 bundle validation has an issue. Created a separate ticket for follow-up: HUDI-7803.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Bundle validation with Java 8 and 11 are skipped in GH CI. This PR reenables them by fixing the
bot.yml.This PR includes changes to make
packaging/bundle-validation/ci_run.shtake the docker container name to avoid name collision in the same GH CI task.Impact
Improves bundle validation coverage.
Risk level
none
Documentation Update
none
Contributor's checklist