[HUDI-7689] Allow users to leverage HoodieTable and Engine Context in Compaction Strategy #11123
+33
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaradar
requested changes
Apr 30, 2024
| * @param hoodieTable a hoodie table which may be used by the compaction strategy | ||
| * @return a new instance of the provided class | ||
| */ | ||
| public static CompactionStrategy create(String strategyClass, HoodieEngineContext hoodieEngineContext, HoodieTable hoodieTable) { |
There was a problem hiding this comment.
@the-other-tim-brown HoodieTable interface exposes different write APIs (insertXXX, bulkInsertXXX, upsertXXX, deleteXXX) which should not be called by the CompactionStrategy implementation.
Can you define an interface to expose the subset of APIs that you want to compaction strategy implementation to make use of ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist