You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves config classes and utils to the proper places:
Moves ConfigProperty, EnumDescription, EnumFieldDescription, HoodieConfig, TypedProperties from hudi-common to hudi-io module so that classes in hudi-io and hudi-hadoop-common modules can use config-related logic.
Moves DFSPropertiesConfiguration class from hudi-common to hudi-hadoop-common module.
Moves HoodieNotSupportedException class used by config utils from hudi-common to hudi-io module.
Moves basic config utils from ConfigUtils in hudi-common module to ConfigUtils in hudi-io module (tests are moved to TestConfigUtils).
Moves Hadoop-related config utils from ConfigUtils to HadoopConfigUtils in hudi-hadoop-common module (tests are moved to TestHadoopConfigUtils).
Moves Hudi-specific config utils from ConfigUtils to HoodieConfigUtils in hudi-common module.
Impact
Code refactoring for reuse and better organization.
Moves ConfigProperty, EnumDescription, EnumFieldDescription, HoodieConfig, TypedProperties from hudi-common to hudi-io module so that classes in hudi-io and hudi-hadoop-common modules can use config-related logic
It may solves the dependency issue, but from the first sight, these classes does not belong to hudi-io IMO, should we have a separate hudi-config module or hudi-api module (that we can put all the code API or interfaces in hudi core).
Moves ConfigProperty, EnumDescription, EnumFieldDescription, HoodieConfig, TypedProperties from hudi-common to hudi-io module so that classes in hudi-io and hudi-hadoop-common modules can use config-related logic
It may solves the dependency issue, but from the first sight, these classes does not belong to hudi-io IMO, should we have a separate hudi-config module or hudi-api module (that we can put all the code API or interfaces in hudi core).
Makes sense. Let me think about this and put up separate PRs.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR moves config classes and utils to the proper places:
ConfigProperty,EnumDescription,EnumFieldDescription,HoodieConfig,TypedPropertiesfromhudi-commontohudi-iomodule so that classes inhudi-ioandhudi-hadoop-commonmodules can use config-related logic.DFSPropertiesConfigurationclass fromhudi-commontohudi-hadoop-commonmodule.HoodieNotSupportedExceptionclass used by config utils fromhudi-commontohudi-iomodule.ConfigUtilsinhudi-commonmodule toConfigUtilsinhudi-iomodule (tests are moved toTestConfigUtils).ConfigUtilstoHadoopConfigUtilsinhudi-hadoop-commonmodule (tests are moved toTestHadoopConfigUtils).ConfigUtilstoHoodieConfigUtilsinhudi-commonmodule.Impact
Code refactoring for reuse and better organization.
Risk level
none
Documentation Update
none
Contributor's checklist