HIVE-28252: AssertionError when using HiveTableScan with a HepPlanner cluster #5244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cluster The HepPlanner does not use any RelTraitDef so the default traitset for the respective cluster is always empty. 1. Relax the assertion to not throw an error when the cluster does not contain a ConventionTraitDef (HepPlanner). 2. Add tests to ensure that it is possible to create a HiveTableScan with VolcanoPlanner and HepPlanner and the expected convention is returned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ConventionTraitDef(HepPlanner).HiveTableScanwithVolcanoPlannerandHepPlannerand the expected convention is returned.Why are the changes needed?
The HepPlanner is heavily used by the optimizer so it makes to be able to create a HiveTableScan with its respective cluster without residing in workarounds (such as requiring the creation of a VolcanoPlanner and obtaining the cluster from there).
More details under HIVE-28252.
Does this PR introduce any user-facing change?
No, anyways assertions are not enabled in production code.
Is the change a dependency upgrade?
No
How was this patch tested?