HIVE-28208: WITH column list doesn't work with CTE materialization #5232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okumin
force-pushed
the
HIVE-28208-cte-mat-column-list
branch
from
54e45a8
to
1fdc90a
Compare
okumin
commented
May 2, 2024
| @@ -8379,7 +8402,9 @@ private ColsAndTypes deriveFileSinkColTypes( | |||
| String colName = colInfo.getInternalName(); //default column name | |||
| if (columns != null) { | |||
| FieldSchema col = new FieldSchema(); | |||
| if (!("".equals(nm[0])) && nm[1] != null) { | |||
| if (i < withColList.size()) { | |||
There was a problem hiding this comment.
Using an input name when is shorter than the input. This follows the behavior of non-materialized CTEs.
If I understand correctly, with-column-list is supported only when the number of columns is exactly equal to that of the query expression. So, it could be an option to disallow colInfos.size() != withColList.size().
okumin
commented
May 2, 2024
| set hive.optimize.cte.materialize.threshold=2; | ||
| set hive.optimize.cte.materialize.full.aggregate.only=false; | ||
| -- Use a format that retains column names | ||
| set hive.default.fileformat=parquet; |
There was a problem hiding this comment.
The default one positionally accesses physical columns, and we can't find some kinds of errors.
okumin
force-pushed
the
HIVE-28208-cte-mat-column-list
branch
from
1fdc90a
to
cb96aaf
Compare
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ANSI SQL supports column aliases for CTEs. Hive also supports it but it fails when CTEs are materialized.
https://issues.apache.org/jira/browse/HIVE-28208
Why are the changes needed?
This patch allows materialized CTEs to obey the standard.
Does this PR introduce any user-facing change?
No. The affected queries never succeed now.
Is the change a dependency upgrade?
No.
How was this patch tested?
I added test queries to
cte_mat_1.q.