New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28219: Support drop partitions by names in IMetaStoreClient #5223
base: master
Are you sure you want to change the base?
Conversation
This PR is followed #4905 (comment), @zhangbutao @dengzhhu653 @deniskuzZ pls take a look in your convenience. |
Quality Gate passedIssues Measures |
Does My concern is that we already have lots of redundant api and other components(Spark/Trino/Impala) may not need the new added api. But if the new added api has some advantages over old api, i think we can move on. I also want to listen to other folks's opinions. :) |
drop partitions by names is not aimed to replace drop by expressions, they each serve distinct purpose. |
+1 This change looks like a variant of If we really need to add it in the future, I would prefer making it an util method instead in |
It's more like a function complement, before this PR, hive client can only drop partitions by exprs, but actually the server side supports drop partitions by names. |
What changes were proposed in this pull request?
In thrift api definition, HMS support to drop partitions by both partition names and expressions. But current api in
IMetaStoreClient
only support drop partitions by expressions, we should add new api to support drop partitions by names.Why are the changes needed?
To improve the
dropPartitions
function.Does this PR introduce any user-facing change?
Yes, user can use the new api to drop partitions by names.
Is the change a dependency upgrade?
No.
How was this patch tested?
Add unit test:
mvn test -Dtest=org.apache.hadoop.hive.ql.metadata.TestHive -pl :hive-exec