HIVE-28194: Regenerate HS2 thrift port in TestRetryingThriftCLIServiceClient #5205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests pending
tests unstable
labels
deniskuzZ
reviewed
Apr 22, 2024
| server.start(); | ||
| Thread.sleep(5000); | ||
| System.out.println("## HiveServer started"); | ||
| private void startHiveServer() throws Exception { |
There was a problem hiding this comment.
that looks similar to TestHS2HttpServer#beforeTests, would be nice to extract common code into a base class and return the port HS2 was started on
There was a problem hiding this comment.
@deniskuzZ I have made a few changes please have a look!
deniskuzZ
reviewed
Apr 22, 2024
|
|
||
| @Before | ||
| public void init() { | ||
| hiveConf = new HiveConf(); | ||
| hiveConf.setVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_BIND_HOST, "localhost"); | ||
| hiveConf.setIntVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_PORT, 15000); | ||
| hiveConf.setIntVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_PORT, port); |
There was a problem hiding this comment.
what's the use of it, since HS2 start is done later and free port could be different?
There was a problem hiding this comment.
Makes sense, reverted it back to 15000
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Hive thrift port was hardcoded to 15000, hence port regeneration code was added here
Why are the changes needed?
Testcase can fail if the port is occupied by another test in testsplit pipeline
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Local machine