HDFS-17532. RBF: Allow router state store cache update to overwrite and delete in parallel #6839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
goiri
changed the title
1 task
ZanderXu
requested changes
May 24, 2024
There was a problem hiding this comment.
@kokonguyen191 thanks for your report. This change makes sense.
The overwrite operation and delete operation should be handled asynchronously, so that the StateStores can be updated in time and avoid unnecessary safe-mode.
The main thread can submit these callables to a threadPoolExecutor and not wait for the result. So that the main thread can return the normal records in time. The newRecords will contain some pending or deleted records, which is different from the current logic, but I thinks it doesn't matter because these pending or deleted records is expired in the newRecords.
For the newRecords
we should use a ThreadPoolExecutor to submit these tasks and
…nd delete in parallel
|
💔 -1 overall
This message was automatically generated. |
ZanderXu
reviewed
May 24, 2024
| if (conf.getBoolean( | ||
| RBFConfigKeys.FEDERATION_STORE_MEMBERSHIP_ASYNC_OVERRIDE, | ||
| RBFConfigKeys.FEDERATION_STORE_MEMBERSHIP_ASYNC_OVERRIDE_DEFAULT)) { | ||
| executor = new ThreadPoolExecutor(2, 2, 1L, TimeUnit.MINUTES, new LinkedBlockingQueue<>()); |
There was a problem hiding this comment.
You can refer HDFS-16848 to change this configuration to the number of threads.
| throw new IOException(e); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
public <R extends BaseRecord> List<R> handleOverwriteAndDelete(List<R> commitRecords,
List<R> deleteRecords) throws IOException {
List<R> result = null;
try {
// overwrite all expired records.
if (commitRecords != null && !commitRecords.isEmpty()) {
Callable<StateStoreOperationResult> overwriteCallable =
() -> putAll(commitRecords, true, false);
if (executor != null) {
executor.submit(overwriteCallable);
} else {
overwriteCallable.call();
}
}
// delete all deletable records.
if (deleteRecords != null && !deleteRecords.isEmpty()) {
Callable<Map<R, Boolean>> deletionCallable = () -> removeMultiple(deleteRecords);
if (executor != null) {
executor.submit(deletionCallable);
} else {
result = new ArrayList<>();
Map<R, Boolean> removedRecords = deletionCallable.call();
for (Map.Entry<R, Boolean> entry : removedRecords.entrySet()) {
if (entry.getValue()) {
result.add(entry.getKey());
}
}
}
}
} catch (Exception e) {
throw new IOException(e);
}
return result;
}
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
merged. Thanks @kokonguyen191 for your report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
This ticket aims to allow the overwrite part and delete part of org.apache.hadoop.hdfs.server.federation.store.CachedRecordStore#overrideExpiredRecords to run in parallel.
Sister ticket to HDFS-17529