GROOVY-9848: in operator: key set membership for isCase(Map,Object)
#1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added tests for GROOVY-2456 as well. This is probably a good time to revisit that item and decide if |
blackdrag
reviewed
Jun 19, 2023
| * <pre class="groovyTestCase">switch( 'foo' ) { | ||
| * case [foo:true, bar:false]: | ||
| * case [foo:true]: |
There was a problem hiding this comment.
To make it really clear I would go one step further and change [foo:true] to [foo:false]
| assert 'foo' in [foo:true] | ||
| assert 'foo' in [foo:null] | ||
| assert 'bar' !in [foo:true] | ||
| assert 'bar' !in [:].withDefault{ true } |
There was a problem hiding this comment.
Again here I would use false as default to be more clear about the keys being used
| // GROOVY-7919 | ||
| void testInForIterables() { | ||
| Iterable iter = { -> ['a','b','c'].iterator() } | ||
| assert 'a' in iter |
There was a problem hiding this comment.
actually it would be nice to do assert 'a' in iter twice to show that the second time it fails
|
I think your idea about leaving isCase alone and changing "in" to use "contains" has merit and is worth exploring as an alternative to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/GROOVY-9848