Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor][cdc] Suppress false alarm in flink config loader #3292

Merged
merged 1 commit into from
May 29, 2024

Conversation

yuxiqian
Copy link
Contributor

@yuxiqian yuxiqian commented May 6, 2024

Currently, Flink CDC supports both new Flink config file config.yaml and fallback legacy config file flink-conf.yaml.

However, a false-alarm "File Not Found" exception will be printed in legacy compatible mode. Using if - else control flow to replace try - catch clause should fix this problem.

@github-actions github-actions bot added the cli label May 6, 2024
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@leonardBang leonardBang merged commit 4a8b587 into apache:master May 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants