Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new metrics from v30 to prometheus-emitter #16345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ztzxt
Copy link
Contributor

@ztzxt ztzxt commented Apr 29, 2024

Description

Added new metrics for prometheus emitter

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@ztzxt
Copy link
Contributor Author

ztzxt commented Apr 29, 2024

Newly introduced metrics in druid release v30 are added per @cryptoe's comment #16340 (comment)

@cryptoe
Copy link
Contributor

cryptoe commented Apr 29, 2024

Thank you @ztzxt for the contribution.

@cryptoe cryptoe added this to the 30.0.0 milestone Apr 29, 2024
@cryptoe
Copy link
Contributor

cryptoe commented May 6, 2024

@ztzxt Could you please rebase this patch on top of the latest master. Post that CI will run

@cryptoe cryptoe removed this from the 30.0.0 milestone May 9, 2024
@ztzxt
Copy link
Contributor Author

ztzxt commented May 21, 2024

hi @cryptoe I just saw your comment. it should be good to go now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants