[improvement](spill) improve spill log printing #34729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40848 ms |
TPC-DS: Total hot run time: 186643 ms |
|
TeamCity be ut coverage result: |
yiguolei
previously approved these changes
May 11, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run external |
yiguolei
reviewed
May 11, 2024
be/src/pipeline/pipeline_task.cpp
Outdated
| @@ -315,7 +315,8 @@ bool PipelineTask::should_revoke_memory(RuntimeState* state, int64_t revocable_m | |||
| wg->check_mem_used(&is_wg_mem_low_water_mark, &is_wg_mem_high_water_mark); | |||
| if (is_wg_mem_high_water_mark) { | |||
| if (revocable_mem_bytes > min_revocable_mem_bytes) { | |||
| LOG_EVERY_N(INFO, 10) << "revoke memory, hight water mark"; | |||
| LOG_EVERY_T(INFO, 1) << "query " << print_id(state->query_id()) | |||
There was a problem hiding this comment.
Not print this log, it should be a debug log.
This method is called by pipeline engine during every loop.
If there is many queries, the log is too often.
yiguolei
reviewed
May 11, 2024
| @@ -201,7 +201,7 @@ void WorkloadGroupMgr::refresh_wg_memory_info() { | |||
| PrettyPrinter::print(process_mem_used, TUnit::BYTES), | |||
| PrettyPrinter::print(sys_mem_available, TUnit::BYTES), | |||
| PrettyPrinter::print(all_queries_mem_used, TUnit::BYTES)); | |||
| VLOG_EVERY_N(1, 10) << debug_msg; | |||
| LOG_EVERY_T(INFO, 1) << debug_msg; | |||
|
run buildall |
github-actions
bot
removed
the
approved
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41897 ms |
TPC-DS: Total hot run time: 187430 ms |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
M1saka2003
pushed a commit
to M1saka2003/doris
that referenced
this pull request
May 14, 2024
ByteYue
pushed a commit
to ByteYue/doris
that referenced
this pull request
May 15, 2024
M1saka2003
pushed a commit
to M1saka2003/doris
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...