[improve](txn insert) Txn load support cloud mode #34721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40555 ms |
TPC-DS: Total hot run time: 185951 ms |
gavinchou
reviewed
May 11, 2024
mymeiyi
force-pushed
the
txn-insert-cloud-2
branch
2 times, most recently
from
8078ba3
to
296f6a1
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41166 ms |
TPC-DS: Total hot run time: 188753 ms |
mymeiyi
force-pushed
the
txn-insert-cloud-2
branch
from
296f6a1
to
1fc1a2b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1332,6 +1332,317 @@ TEST(MetaServiceTest, CommitTxnExpiredTest) { | |||
| } | |||
| } | |||
|
|
|||
| TEST(MetaServiceTest, CommitTxnWithSubTxnTest) { | |||
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(MetaServiceTest, CommitTxnWithSubTxnTest) {
^Additional context
cloud/test/meta_service_test.cpp:1334: 187 lines including whitespace and comments (threshold 80)
TEST(MetaServiceTest, CommitTxnWithSubTxnTest) {
^| } | ||
| } | ||
|
|
||
| TEST(MetaServiceTest, BeginAndAbortSubTxnTest) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(MetaServiceTest, BeginAndAbortSubTxnTest) {
^Additional context
cloud/test/meta_service_test.cpp:1523: 120 lines including whitespace and comments (threshold 80)
TEST(MetaServiceTest, BeginAndAbortSubTxnTest) {
^
mymeiyi
force-pushed
the
txn-insert-cloud-2
branch
from
1fc1a2b
to
a493ddf
Compare
| @@ -1332,6 +1332,313 @@ TEST(MetaServiceTest, CommitTxnExpiredTest) { | |||
| } | |||
| } | |||
|
|
|||
| TEST(MetaServiceTest, CommitTxnWithSubTxnTest) { | |||
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(MetaServiceTest, CommitTxnWithSubTxnTest) {
^Additional context
cloud/test/meta_service_test.cpp:1334: 185 lines including whitespace and comments (threshold 80)
TEST(MetaServiceTest, CommitTxnWithSubTxnTest) {
^| } | ||
| } | ||
|
|
||
| TEST(MetaServiceTest, BeginAndAbortSubTxnTest) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(MetaServiceTest, BeginAndAbortSubTxnTest) {
^Additional context
cloud/test/meta_service_test.cpp:1521: 118 lines including whitespace and comments (threshold 80)
TEST(MetaServiceTest, BeginAndAbortSubTxnTest) {
^
|
run buildall |
TPC-H: Total hot run time: 41841 ms |
TPC-DS: Total hot run time: 187484 ms |
ClickBench: Total hot run time: 30.74 s |
| } | ||
| } | ||
|
|
||
| TEST(MetaServiceTest, BeginAndAbortSubTxnTest) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(MetaServiceTest, BeginAndAbortSubTxnTest) {
^Additional context
cloud/test/meta_service_test.cpp:1521: 119 lines including whitespace and comments (threshold 80)
TEST(MetaServiceTest, BeginAndAbortSubTxnTest) {
^
|
run buildall |
mymeiyi
force-pushed
the
txn-insert-cloud-2
branch
from
4c9df64
to
80a107e
Compare
|
run buildall |
mymeiyi
force-pushed
the
txn-insert-cloud-2
branch
from
80a107e
to
94bc14a
Compare
mymeiyi
force-pushed
the
txn-insert-cloud-2
branch
from
94bc14a
to
16a2691
Compare
|
run buildall |
TPC-DS: Total hot run time: 182574 ms |
ClickBench: Total hot run time: 30.28 s |
|
run buildall |
TPC-H: Total hot run time: 40766 ms |
TPC-DS: Total hot run time: 180656 ms |
ClickBench: Total hot run time: 31.21 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run cloud_p0 cloud_ut |
|
run cloud_p0 |
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 41995 ms |
TPC-DS: Total hot run time: 168882 ms |
ClickBench: Total hot run time: 30.79 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As the title and leave a todo: Cloud does not support mow table in txn load.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...