[opt](profile) Avoid unnecessary copies in the profile thrift. #34720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41331 ms |
TPC-DS: Total hot run time: 188467 ms |
|
TeamCity be ut coverage result: |
| @@ -126,15 +134,16 @@ TReportExecStatusParams RuntimeQueryStatiticsMgr::create_report_exec_status_para | |||
| } | |||
|
|
|||
| TDetailedReportParams tmp; | |||
| tmp.__set_profile(*pipeline_profile); | |||
| tmp.__isset.profile = true; | |||
| tmp.profile = std::move(*pipeline_profile); | |||
There was a problem hiding this comment.
does this move safe? the original object will be broken
| @@ -151,15 +160,17 @@ TReportExecStatusParams RuntimeQueryStatiticsMgr::create_report_exec_status_para | |||
| continue; | |||
| } | |||
|
|
|||
| load_channel_profiles_req.push_back(*load_channel_profile); | |||
| load_channel_profiles_req.push_back(std::move(*load_channel_profile)); | |||
There was a problem hiding this comment.
original object will be broken
be/src/service/backend_service.cpp
Outdated
| RuntimeProfile::Counter get_realtime_timer {TUnit::TIME_NS}; | ||
|
|
||
| Defer _print_log([&]() { | ||
| LOG_INFO("Getting realtime exec status cost {}", |
There was a problem hiding this comment.
LOG_WARNING if we meet some threshold
|
run buildall |
TPC-H: Total hot run time: 42000 ms |
TPC-DS: Total hot run time: 187641 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
TPC-H: Total hot run time: 41545 ms |
TPC-DS: Total hot run time: 187370 ms |
|
TeamCity be ut coverage result: |
|
run cloud_p1 |
HappenLee
reviewed
May 14, 2024
HappenLee
reviewed
May 14, 2024
| } | ||
|
|
||
| TReportExecStatusParams req; | ||
| req.__set_query_profile(profile); |
There was a problem hiding this comment.
check the thrift api have a better way？
likereq.__set_query_profile(std::move(profile)
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
HappenLee
reviewed
May 20, 2024
| // This function will clear the data of fragment_id_to_profile and load_channel_profiles. | ||
| RuntimeProfile::Counter timer {TUnit::TIME_NS}; | ||
| Defer _print_log([&]() { | ||
| LOG_INFO("Create report exec status params cost {}", |
There was a problem hiding this comment.
why we need log each profile report time？
HappenLee
reviewed
May 20, 2024
be/src/util/thrift_client.h
Outdated
| @@ -38,6 +38,11 @@ class TTransport; | |||
| } // namespace apache | |||
|
|
|||
| namespace doris { | |||
|
|
|||
| #define SET_THRIFT_VALUES(thrift, member, value) \ | |||
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Gabriel39
approved these changes
May 21, 2024
M1saka2003
pushed a commit
to M1saka2003/doris
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
need this pr
#34693
before
now
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...