[fix](Nereids) check pushDownContext validation after withNewProbeExpression() #34704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
morrySnow
approved these changes
May 11, 2024
|
add test case please |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
run clouldp1 |
|
run cloudp1 |
|
run cloud_p1 |
starocean999
approved these changes
May 12, 2024
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
May 12, 2024
…he#34704) when the runtime filter target to a constant, the PushDownContext.finalTarget is null. in this case, do not pushdown runtime filter. example: select * from (select 1 as x from T1) T2 join T3 on T2.x=T3.x when push down RF(T3.x->T2.x) inside "select 1 as x from T1", the column x is a constant, and the pushDown stopped. (cherry picked from commit 7f06cf0)
englefly
added a commit
that referenced
this pull request
May 12, 2024
…) (#34737) when the runtime filter target to a constant, the PushDownContext.finalTarget is null. in this case, do not pushdown runtime filter. example: select * from (select 1 as x from T1) T2 join T3 on T2.x=T3.x when push down RF(T3.x->T2.x) inside "select 1 as x from T1", the column x is a constant, and the pushDown stopped. (cherry picked from commit 7f06cf0)
M1saka2003
pushed a commit
to M1saka2003/doris
that referenced
this pull request
May 14, 2024
…he#34704) when the runtime filter target to a constant, the PushDownContext.finalTarget is null. in this case, do not pushdown runtime filter. example: select * from (select 1 as x from T1) T2 join T3 on T2.x=T3.x when push down RF(T3.x->T2.x) inside "select 1 as x from T1", the column x is a constant, and the pushDown stopped.
ByteYue
pushed a commit
to ByteYue/doris
that referenced
this pull request
May 15, 2024
…he#34704) when the runtime filter target to a constant, the PushDownContext.finalTarget is null. in this case, do not pushdown runtime filter. example: select * from (select 1 as x from T1) T2 join T3 on T2.x=T3.x when push down RF(T3.x->T2.x) inside "select 1 as x from T1", the column x is a constant, and the pushDown stopped.
M1saka2003
pushed a commit
to M1saka2003/doris
that referenced
this pull request
May 24, 2024
…he#34704) when the runtime filter target to a constant, the PushDownContext.finalTarget is null. in this case, do not pushdown runtime filter. example: select * from (select 1 as x from T1) T2 join T3 on T2.x=T3.x when push down RF(T3.x->T2.x) inside "select 1 as x from T1", the column x is a constant, and the pushDown stopped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
when the runtime filter target to a constant, the PushDownContext.finalTarget is null.
in this case, do not pushdown runtime filter.
example:
select * from (select 1 as x from T1) T2 join T3 on T2.x=T3.x
when push down RF(T3.x->T2.x) inside "select 1 as x from T1", the column x is a constant, and the pushDown stopped.
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...