Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iOS) Avoid repetitive permission prompts #1245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jancabadaj
Copy link

Platforms affected

iOS

Motivation and Context

resolves #1166

Description

If the app uses WebRTC, the user is initially prompted for permission twice, and then prompted again each time the app is restarted.

The solution is inspired by react:
react-native-webview/react-native-webview#2257

Testing

I tested the changes in a project that is using WebRTC camera streaming.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@vbraun
Copy link
Contributor

vbraun commented Feb 23, 2023

Works for me, for what its worth!

I would consider setting the default to "grant" because nobody wants the repeated permission request.

@dpogue dpogue added this to the 7.0.0 milestone May 7, 2023
@dpogue dpogue modified the milestones: 7.0.0, 7.1.0 Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants