Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug alert() iOS #1121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix bug alert() iOS #1121

wants to merge 1 commit into from

Conversation

Luo-Kuang
Copy link

Platforms affected

iOS

Motivation and Context

issues #1120

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • [x ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [x ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [x ] I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #1121 (1eee12b) into master (8a6569c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1121   +/-   ##
=======================================
  Coverage   74.86%   74.86%           
=======================================
  Files          13       13           
  Lines        1723     1723           
=======================================
  Hits         1290     1290           
  Misses        433      433           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6569c...1eee12b. Read the comment docs.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me. I'm not sure it needs to be a class method rather than an instance method, but the idea seems good

@@ -160,4 +159,29 @@ - (void)webViewDidClose:(WKWebView*)webView
}


+ (UIViewController *)topViewController {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this to be a static method on CDVWebViewUIDelegate rather than an instance method used with [self topViewController]? It looks like all uses of it are within the CDVWebViewUIDelegate class

@dpogue dpogue added this to the 7.0.0 milestone Apr 15, 2023
@dpogue dpogue modified the milestones: 7.0.0, 7.0.1 Aug 29, 2023
@dpogue dpogue removed this from the 7.0.1 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app hang while showing alert when select dropdown box is actively showing
4 participants