Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: changed the method called due to deprecation #1405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andredestro
Copy link

Platforms affected

Android

Motivation and Context

CordovaInterfaceImpl is calling a deprecated method of CordovaPlugin.

Fixes #1388

Description

Simply replaces the onRequestPermissionResult by onRequestPermissionsResult.

Testing

Created a new Cordova android app with a plugin that requests camera permission.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek changed the title fix: changed the method called due to depreciation fix: changed the method called due to deprecation May 19, 2022
@breautek breautek changed the title fix: changed the method called due to deprecation fix(breaking): changed the method called due to deprecation May 19, 2022
@jcesarmobile jcesarmobile changed the title fix(breaking): changed the method called due to deprecation fix!: changed the method called due to deprecation Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onRequestPermissionResult deprecation issue
1 participant