[IMAGING-340] Support PNG extension #269
Conversation
|
FYI, this will not be considered without unit tests. |
Before that, I need to find a way to generate test data. |
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
============================================
- Coverage 70.76% 70.67% -0.09%
- Complexity 3368 3377 +9
============================================
Files 332 334 +2
Lines 16936 16991 +55
Branches 2652 2651 -1
============================================
+ Hits 11985 12009 +24
- Misses 3904 3927 +23
- Partials 1047 1055 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Glavo
changed the title
|
When I created the test, I noticed the type of However, in the standard document, the field type is SHORT or LONG. Unfortunately, the test image I found uses the LONG type field to record Should I solve this problem in this PR? Or do I need to open a new PR? |
Glavo
changed the title
|
I updated this PR, followed the requirements of IMAGING-341, and recorded the standard version in the document. Can someone review this PR? |
| * and supports the following extensions: | ||
| * <ul> | ||
| * <li><a href="http://ftp-osl.osuosl.org/pub/libpng/documents/pngext-1.5.0.html">Extensions to the PNG 1.2 Specification, Version 1.5.0</a></li> | ||
| * </ul> |
src/main/java/org/apache/commons/imaging/formats/png/PngImageMetadata.java
Show resolved
Hide resolved
| } else { | ||
| result.add(new PngChunk(length, chunkType, crc, bytes)); | ||
| } | ||
| result.add(ChunkType.makeChunk(length, chunkType, crc, bytes)); |
src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
Show resolved
Hide resolved
src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
Show resolved
Hide resolved
|
The javadoc has been updated to add the |
|
@Glavo Thank you! I don’t know if this PR will ever be pulled, because by now I think that this project is pretty much dead. But you did not waste your time on this, because I pulled it into my Kotlin port Ashampoo Kim. So you may be glad to hear that your code is used in production (for example by Ashampoo Photos) and people benefit from it. 🙂 I invite you to contribute directly to my fork in the future. |
Certainly not dead. Maintained by volunteers, yes. I am busy with deadlines at work, but watching and planning a future development cycle, fix security bugs (a lot happens there without activity on GitHub for a reason, so again, not dead). I think it is good to have more projects like what you created to give more options to users. But leave a comment saying a project is dead and promote your own tool doesn't look very good, IMHO. And apologies again for the radio silence, just busy with $work and not able to volunteer time at this point (happy if any other committer takes over, otherwise March I should be available). Cheers |
|
Thank you for reaching out and providing an update. I must admit, I've encountered some frustration recently. Over the past few months, the only noticeable activity on the project seems to be from Gary, who has been addressing minor style issues but not significantly contributing otherwise. It appears he hasn't been thoroughly reviewing code in pull requests and may not grasp the project's domain. Even without unit tests, confirming the correctness of the bugfix in my pull request or validating the provided test should have been straightforward for someone familiar with the codebase and its intricacies. This is the kind of scrutiny and understanding that someone actively engaged in the project could provide. I recall observing this level of engagement from you some time ago, which is why I directed my concerns to you. Maybe the project isn’t dead, given the abundance of open issues and pull requests coupled with the lack of substantial development, it's difficult to characterize it as an actively progressing endeavor. I am glad to hear that you plan to pick up the work here, because this project deserves real maintenance. How Gary acts on my PRs is just ridiculous. First he wanted me to include a test image and provide a test - both would not have been necessary. After I did go the extra mile he doesn’t want the test (because he does not seem to understand what it does) and now all of the sudden the inclusion of the test image is a problem. That’s really sad and ridiculous maintenance. I believe this projects deserves better. |
|
I understand the frustration @StefanOltmann , and I am sure there are ways to improve how we interact here (on both ends, including myself). I have not followed everything that's happening due to these $work projects/deadlines, but I will try to catch up with everything that is happening and slowly start to review issues and pull requests, and also fix the security warnings we have. Feel free to ping me in issues/pull requests if you'd like, just expect some delays until the end of this month 👍 And as for your interaction with Gary/others, please consider that they are trying to help as I was the last person more actively working, but I have been away for some months now (apologies, again). They are trying to help as much as they can, and there can be some misunderstanding, but finding a way to work well and communicate your frustrations clearly and politely is key -- not only for ASF, but for your own personal open source projects 👍 |
|
This component is definitely not dead. |
I hope to support Extensions to the PNG 1.2 Specification, Version 1.5.0 in this PR and be ready to support the APNG file format in subsequent PR.
Completed works:
PngImageParser::readChunksandChunkTypeto improve maintainability makes it easier to add new Chunk types later;