Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update AddAccountOrUserToProject to show a drop down for account & user #9072

Open
wants to merge 1 commit into
base: 4.19
Choose a base branch
from

Conversation

vishesh92
Copy link
Member

@vishesh92 vishesh92 commented May 10, 2024

Description

This PR fixes #7216

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

image

image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92 vishesh92 force-pushed the ui-update-add-account-to-project branch from 4bb70bf to db68ab3 Compare May 10, 2024 07:48
@vishesh92 vishesh92 changed the title UI: Update AddAccountOrUserToProject to show a drop down for account … UI: Update AddAccountOrUserToProject to show a drop down for account & user May 10, 2024
@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.96%. Comparing base (ea9a0f4) to head (db68ab3).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9072      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10995    10992       -3     
============================================
  Files          5373     5373              
  Lines        469024   469031       +7     
  Branches      58818    60697    +1879     
============================================
- Hits          70197    70187      -10     
- Misses       391056   391074      +18     
+ Partials       7771     7770       -1     
Flag Coverage Δ
uitests 4.31% <ø> (-0.01%) ⬇️
unittests 15.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9072 (QA-JID-339)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, tested in QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants