cks: fix events

[shwstppr]

Description

Fixes #8043

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 9.03614% with 151 lines in your changes are missing coverage. Please review.

Project coverage is 14.96%. Comparing base (87e7c57) to head (29c94e0).
Report is 4 commits behind head on 4.19.

Files	Patch %	Lines
...bernetes/cluster/KubernetesClusterManagerImpl.java	0.00%	34 Missing ⚠️
...ubernetes/cluster/KubernetesServiceHelperImpl.java	0.00%	31 Missing ⚠️
...s/version/UpdateKubernetesSupportedVersionCmd.java	0.00%	7 Missing ⚠️
...r/actionworkers/KubernetesClusterActionWorker.java	0.00%	6 Missing ⚠️
...kubernetes/cluster/DeleteKubernetesClusterCmd.java	0.00%	6 Missing ⚠️
.../apache/cloudstack/api/ApiCommandResourceType.java	44.44%	4 Missing and 1 partial ⚠️
...KubernetesClusterResourceModifierActionWorker.java	0.00%	5 Missing ⚠️
...bernetes/version/KubernetesVersionManagerImpl.java	50.00%	5 Missing ⚠️
.../kubernetes/cluster/StartKubernetesClusterCmd.java	0.00%	5 Missing ⚠️
...e/cloudstack/annotation/AnnotationManagerImpl.java	0.00%	5 Missing ⚠️
... and 14 more

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9070      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10995    10992       -3     
============================================
  Files          5373     5373              
  Lines        469005   469130     +125     
  Branches      58953    58719     -234     
============================================
- Hits          70198    70195       -3     
- Misses       391036   391163     +127     
- Partials       7771     7772       +1     

Flag	Coverage Δ
uitests	4.31% <ø> (-0.01%)	⬇️
unittests	15.66% <9.03%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9611

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9621

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9636

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-10217)

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

code looks good @shwstppr , if I read this correctly it adds (fixes) a lot more events than the one reported in #8043 . Is this worth a doc PR?

[shwstppr]

@DaanHoogland this PR just fixes events for different CKS actions for both k8s cluster and k8s supported versions. Mainly the resources linked to the events. I'm not sure what can be added in a doc PR. Do you have any suggestions?

[DaanHoogland]

@DaanHoogland this PR just fixes events for different CKS actions for both k8s cluster and k8s supported versions. Mainly the resources linked to the events. I'm not sure what can be added in a doc PR. Do you have any suggestions?

It is not specific to this PR, but I think we can look at more specific event documentation. I had a quick search of the docs and do not see any event documentation for other resources either. Just a thought. Forget it for now.

[blueorangutan]

[SF] Trillian test result (tid-10234)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43609 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9070-t10234-kvm-centos7.zip
Smoke tests completed. 129 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	418.55	test_events_resource.py
test_02_trigger_shutdown	Failure	341.77	test_safe_shutdown.py