New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix dashboard limit format #9060
ui: fix dashboard limit format #9060
Conversation
An undefined variable `item` was used. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9060 +/- ##
============================================
- Coverage 14.96% 14.96% -0.01%
+ Complexity 10995 10990 -5
============================================
Files 5373 5373
Lines 469005 469024 +19
Branches 58953 58330 -623
============================================
- Hits 70198 70183 -15
- Misses 391036 391071 +35
+ Partials 7771 7770 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test but LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn’t test though
@shwstppr , I see no difference between your before and after pictures. Can you highlight what has changed, please? |
@DaanHoogland there is a difference in before and after screens. There is no percentage label for unlimited resource types (check Instances label) More importantly in certain scenarios, the code itself is incorrect using the wrong variables. It may log an error similar to that reported in #9045 in certain cases while trying to find |
Description
An undefined variable
item
was used.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?
How did you try to break this feature and the system with this change?