pre-commit: enable Python Flake8 rule E713

[jbampton]

https://www.flake8rules.com/rules/E713.html

Description

This PR adds another check or test to our Python linting framework.

Sets a consistent code standard and stops regressions.

"Test for membership should be 'not in' (E713)"

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran:

pre-commit run --all-files

How did you try to break this feature and the system with this change?

[DaanHoogland]

clgtm, needs testing

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.28%. Comparing base (0d8f7d4) to head (e41942f).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #9016   +/-   ##
=========================================
  Coverage     15.28%   15.28%           
+ Complexity    11523    11522    -1     
=========================================
  Files          5425     5425           
  Lines        474008   474008           
  Branches      61750    61779   +29     
=========================================
+ Hits          72445    72450    +5     
+ Misses       393518   393514    -4     
+ Partials       8045     8044    -1     

Flag	Coverage Δ
uitests	4.26% <ø> (ø)
unittests	16.01% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9488

[jbampton]

@blueorangutan package

[blueorangutan]

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9569

[weizhouapache]

code lgtm

not tested

[DaanHoogland]

@blueorangutan test

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-10210)

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10241)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48008 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9016-t10241-kvm-centos7.zip
Smoke tests completed. 129 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	418.10	test_events_resource.py
test_08_arping_in_ssvm	Failure	5.21	test_diagnostics.py
test_09_arping_in_cpvm	Failure	5.20	test_diagnostics.py