build/packaging: build tungsten plugin only if noredist is passed

[weizhouapache]

Description

This PR moves tungsten plugin from normal packaging to noredist packaging

it also removes the maven repository for juniper-tungsten-api
whoever want to build tungsten, please install the jar manually. please refer to https://github.com/shapeblue/cloudstack-nonoss/
./install-non-oss.sh

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 12.24%. Comparing base (9d5d4e5) to head (a6f680b).
Report is 1 commits behind head on 4.18.

Files	Patch %	Lines
...ain/java/com/cloud/network/NetworkServiceImpl.java	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.18    #9006    +/-   ##
==========================================
  Coverage     12.24%   12.24%            
  Complexity     9291     9291            
==========================================
  Files          4698     4694     -4     
  Lines        414259   414127   -132     
  Branches      51377    51009   -368     
==========================================
- Hits          50707    50701     -6     
+ Misses       357251   357126   -125     
+ Partials       6301     6300     -1     

Flag	Coverage Δ
unittests	12.24% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9483

[weizhouapache]

@blueorangutan test rocky8 kvm-rocky8

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

[DaanHoogland]

code looks good so far @weizhouapache , but you are adding four agent commands without answers or calling them. What can we expect on this?

[weizhouapache]

code looks good so far @weizhouapache , but you are adding four agent commands without answers or calling them. What can we expect on this?

@DaanHoogland
The kvm plugin has dependency on tungsten currently. Since tungsten will be moved to noredist packaging, to not break the regular packaging (without noredist), I remove tungsten from kvm plugin.
4 tungsten classes (as you have noticed) are still used by the kvm plugin, I have to add the copies to kvm plugin, otherwise the compilation of kvm plugin will fail.

[blueorangutan]

[SF] Trillian test result (tid-10093)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44986 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9006-t10093-kvm-rocky8.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

clgtm

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9513

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9515

[weizhouapache]

@blueorangutan test matrix

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[sureshanaparti]

@weizhouapache need to update this file deps/install-non-oss.sh here?

[sureshanaparti]

clgtm

[weizhouapache]

@weizhouapache need to update this file deps/install-non-oss.sh here?

yep, the jar has already been added last year I think

[weizhouapache]

@weizhouapache need to update this file deps/install-non-oss.sh here?

yep, the jar has already been added last year I think

sorry @sureshanaparti
I thought you mentioned the script in cloudstack-nonoss repo. It has been updated.

The script in deps folder is not well maintained, the last change was 4 years ago. I will create a separated pr for it.

[blueorangutan]

[SF] Trillian test result (tid-10139)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41084 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9006-t10139-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

[SF] Trillian test result (tid-10137)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43441 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9006-t10137-xenserver-71.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

[SF] Trillian test result (tid-10138)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 62940 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9006-t10138-vmware-67u3.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	3661.45	test_kubernetes_clusters.py

[weizhouapache]

This is ready for review and testing

[DaanHoogland]

@weizhouapache does it need further testing? (and what kind)

[weizhouapache]

@weizhouapache does it need further testing? (and what kind)

no idea what needs to be tested
probably tungsten :-D