api,server: purge expunged resources #8999

shwstppr · 2024-04-29T06:18:56Z

Description

Feature spec: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Purge+Expunged+Resources

This PR introduces the functionality of purging removed DB entries for CloudStack entities (currently only for VirtualMachine). There would be three mechanisms for purging removed resources:

Background task - CloudStack will run a background task which runs at a defined interval. Other parameters for this task can be controlled with new global settings.
API - New admin-only API purgeExpungedResources. It will allow passing the following parameters - resourcetype, batchsize, startdate, enddate. Currently, API is not supported in the UI.
Config for service offering. Service offerings can be created with purgeresources parameter which would allow purging resources immediately on expunge.

Following new global settings have been added:

expunged.resources.purge.enabled: Default: false. Whether to run a background task to purge the expunged resources
expunged.resources.purge.resources: Default: (empty). A comma-separated list of resource types that will be considered by the background task to purge the expunged resources. Currently only VirtualMachine is supported. An empty "value will result in considering all resource types for purging
expunged.resources.purge.interval: Default: 86400. Interval (in seconds) for the background task to purge the expunged resources
expunged.resources.purge.delay: Default: 300. Initial delay (in seconds) to start the background task to purge the expunged resources task.
expunged.resources.purge.batch.size: Default: 50. Batch size to be used during expunged resources purging.
expunged.resources.purge.start.time: Default: (empty). Start time to be used by the background task to purge the expunged resources. Use format yyyy-MM-dd or yyyy-MM-dd HH:mm:ss.
expunged.resources.purge.keep.past.days: Default: 30. The number of days in the past from the execution time of the background task to purge the expunged resources for which the expunged resources must not be purged. To enable purging expunged resource till the execution of the background task, set the value to zero.
expunged.resource.purge.job.delay: Default: 180. Delay (in seconds) to execute the purging of an expunged resource initiated by the configuration in the offering. Minimum value should be 180 seconds and if a lower value is set then the minimum value will be used.

Documentation PR: apache/cloudstack-documentation#397

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

API usage:

> purge expungedresources startdate=2024-04-15 enddate=2024-04-20 resourcetype=VirtualMachine
{
  "purgeexpungedresourcesresponse": {
    "resourcecount": 6
  }
}

Verified new smoke test,

[root@pr8999-t6925-kvm-centos7-marvin marvin]# nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=./pr8999-t6925-kvm-centos7-advanced-cfg -s -a tags=advanced --hypervisor=KVM tests/smoke/test_purge_expunged_vms.py
/usr/local/lib/python3.6/site-packages/paramiko/transport.py:32: CryptographyDeprecationWarning: Python 3.6 is no longer supported by the Python core team. Therefore, support for it is deprecated in cryptography. The next release of cryptography will remove support for Python 3.6.
  from cryptography.hazmat.backends import default_backend

==== Marvin Init Started ====

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

==== Log Folder Path: /marvin/MarvinLogs/May_01_2024_08_09_34_TNMKB9 All logs will be available here ====

=== Marvin Init Logging Successful===

==== Marvin Init Successful ====
=== TestName: test_01_purge_expunged_api_vm_start_date | Status : SUCCESS ===

=== TestName: test_02_purge_expunged_api_vm_end_date | Status : SUCCESS ===

=== TestName: test_03_purge_expunged_api_vm_start_end_date | Status : SUCCESS ===

=== TestName: test_04_purge_expunged_api_vm_no_date | Status : SUCCESS ===

=== TestName: test_05_purge_expunged_vm_service_offering | Status : SUCCESS ===

{'mgtSvrIp': '10.1.33.150', 'port': 8080, 'user': 'root', 'passwd': 'P@ssword123', 'hypervisor': 'kvm', 'useHttps': 'False', 'certCAPath': 'NA', 'certPath': 'NA', 'apiKey': 'YZDWI356FRnLh8vEHROd_ZUVD5U8JeGG-mObb7wPhyL5OQqi6df3KCmF5AlVWxPsZvsvNY2-z9BbyqSZGPaBCg', 'securityKey': 'U4LP9-ZdTuRl4_hJl3x2KN6nTNZCYAWhcMXmFKBSBYTNoUghjj3Pb5-0s2hN_tVG0l8oK6jDrmp953NOP59GAg'}
====Trying SSH Connection: Host:10.1.33.150 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.1.33.150 port : 22 SUCCESSFUL===
{Cmd: service cloudstack-management stop via Host: 10.1.33.150} {returns: ['Redirecting to /bin/systemctl stop cloudstack-management.service']}
{Cmd: service cloudstack-management start via Host: 10.1.33.150} {returns: ['Redirecting to /bin/systemctl start cloudstack-management.service']}
====Trying SSH Connection: Host:10.1.35.104 User:root                                   Port:22 RetryCnt:60===
====Trying SSH Connection: Host:10.1.35.104 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.1.35.104 port : 22 SUCCESSFUL===
===SSH to Host 10.1.35.104 port : 22 SUCCESSFUL===
{Cmd: service cloudstack-management stop via Host: 10.1.35.104} {returns: ['Redirecting to /bin/systemctl stop cloudstack-management.service']}
{Cmd: service cloudstack-management start via Host: 10.1.35.104} {returns: ['Redirecting to /bin/systemctl start cloudstack-management.service']}
{'mgtSvrIp': '10.1.33.150', 'port': 8080, 'user': 'root', 'passwd': 'P@ssword123', 'hypervisor': 'kvm', 'useHttps': 'False', 'certCAPath': 'NA', 'certPath': 'NA', 'apiKey': 'YZDWI356FRnLh8vEHROd_ZUVD5U8JeGG-mObb7wPhyL5OQqi6df3KCmF5AlVWxPsZvsvNY2-z9BbyqSZGPaBCg', 'securityKey': 'U4LP9-ZdTuRl4_hJl3x2KN6nTNZCYAWhcMXmFKBSBYTNoUghjj3Pb5-0s2hN_tVG0l8oK6jDrmp953NOP59GAg'}
====Trying SSH Connection: Host:10.1.33.150 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.1.33.150 port : 22 SUCCESSFUL===
{Cmd: service cloudstack-management stop via Host: 10.1.33.150} {returns: ['Redirecting to /bin/systemctl stop cloudstack-management.service']}
{Cmd: service cloudstack-management start via Host: 10.1.33.150} {returns: ['Redirecting to /bin/systemctl start cloudstack-management.service']}
====Trying SSH Connection: Host:10.1.35.104 User:root                                   Port:22 RetryCnt:60===
====Trying SSH Connection: Host:10.1.35.104 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.1.35.104 port : 22 SUCCESSFUL===
===SSH to Host 10.1.35.104 port : 22 SUCCESSFUL===
{Cmd: service cloudstack-management stop via Host: 10.1.35.104} {returns: ['Redirecting to /bin/systemctl stop cloudstack-management.service']}
{Cmd: service cloudstack-management start via Host: 10.1.35.104} {returns: ['Redirecting to /bin/systemctl start cloudstack-management.service']}
=== TestName: test_06_purge_expunged_vm_background_task | Status : SUCCESS ===

codecov-commenter · 2024-04-29T06:27:52Z

Codecov Report

Attention: Patch coverage is 34.04005% with 560 lines in your changes are missing coverage. Please review.

Project coverage is 15.31%. Comparing base (f41c934) to head (8bca921).
Report is 19 commits behind head on main.

Files	Patch %	Lines
...loudstack/resource/ResourceCleanupServiceImpl.java	50.51%	220 Missing and 20 partials ⚠️
...c/main/java/com/cloud/utils/db/GenericDaoBase.java	0.00%	35 Missing ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java	0.00%	25 Missing ⚠️
...a/com/cloud/vm/snapshot/dao/VMSnapshotDaoImpl.java	0.00%	20 Missing ⚠️
.../main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java	0.00%	16 Missing ⚠️
...main/java/com/cloud/storage/dao/VolumeDaoImpl.java	0.00%	11 Missing ⚠️
...udstack/resourcedetail/ResourceDetailsDaoBase.java	0.00%	10 Missing ⚠️
...mand/admin/resource/PurgeExpungedResourcesCmd.java	72.72%	9 Missing ⚠️
...tack/engine/orchestration/NetworkOrchestrator.java	0.00%	9 Missing ⚠️
...d/network/as/dao/AutoScaleVmGroupVmMapDaoImpl.java	0.00%	9 Missing ⚠️
... and 26 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8999      +/-   ##
============================================
+ Coverage     15.28%   15.31%   +0.03%     
- Complexity    11521    11587      +66     
============================================
  Files          5425     5430       +5     
  Lines        473992   474909     +917     
  Branches      59026    58073     -953     
============================================
+ Hits          72439    72755     +316     
- Misses       393510   394080     +570     
- Partials       8043     8074      +31

Flag	Coverage Δ
uitests	`4.26% <ø> (-0.01%)`	⬇️
unittests	`16.05% <34.04%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Feature PR: apache/cloudstack#8999 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2024-04-29T10:50:11Z

@blueorangutan package

blueorangutan · 2024-04-29T10:52:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-29T11:59:04Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9464

shwstppr · 2024-04-29T12:02:11Z

@blueorangutan test

blueorangutan · 2024-04-29T12:04:03Z

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-04-29T12:24:30Z

[SF] Trillian Build Failed (tid-10080)

shwstppr · 2024-04-30T05:00:20Z

@blueorangutan package

blueorangutan · 2024-04-30T05:02:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-30T06:17:17Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9471

This PR introduces the functionality of purging removed DB entries for CloudStack entities (currently only for VirtualMachine). There would be three mechanisms for purging removed resources: Background task - CloudStack will run a background task which runs at a defined interval. Other parameters for this task can be controlled with new global settings. API - New admin-only API purgeExpungedResources. It will allow passing the following parameters - resourcetype, batchsize, startdate, enddate. Currently, API is not supported in the UI. Config for service offering. Service offerings can be created with purgeresources parameter which would allow purging resources immediately on expunge. Following new global settings have been added: expunged.resources.purge.enabled: Default: false. Whether to run a background task to purge the expunged resources expunged.resources.purge.resources: Default: (empty). A comma-separated list of resource types that will be considered by the background task to purge the expunged resources. Currently only VirtualMachine is supported. An empty "value will result in considering all resource types for purging expunged.resources.purge.interval: Default: 86400. Interval (in seconds) for the background task to purge the expunged resources expunged.resources.purge.delay: Default: 300. Initial delay (in seconds) to start the background task to purge the expunged resources task. expunged.resources.purge.batch.size: Default: 50. Batch size to be used during expunged resources purging. expunged.resources.purge.start.time: Default: (empty). Start time to be used by the background task to purge the expunged resources. Use format yyyy-MM-dd or yyyy-MM-dd HH:mm:ss. expunged.resources.purge.keep.past.days: Default: 30. The number of days in the past from the execution time of the background task to purge the expunged resources for which the expunged resources must not be purged. To enable purging expunged resource till the execution of the background task, set the value to zero. expunged.resource.purge.job.delay: Default: 180. Delay (in seconds) to execute the purging of an expunged resource initiated by the configuration in the offering. Minimum value should be 180 seconds and if a lower value is set then the minimum value will be used. Documentation PR: apache/cloudstack-documentation#397 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

blueorangutan · 2024-04-30T10:22:44Z

[SF] Trillian Build Failed (tid-10089)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2024-04-30T17:46:18Z

@blueorangutan package

blueorangutan · 2024-04-30T17:48:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

blueorangutan · 2024-04-30T19:12:02Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9490

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2024-04-30T19:54:10Z

@blueorangutan test

blueorangutan · 2024-04-30T19:56:03Z

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-04-30T20:22:31Z

[SF] Trillian Build Failed (tid-10101)

blueorangutan · 2024-05-02T10:26:00Z

[SF] Trillian test result (tid-10109)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 91139 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8999-t10109-xenserver-71.zip
Smoke tests completed. 129 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	352.70	test_events_resource.py
test_01_purge_expunged_api_vm_start_date	`Failure`	3904.59	test_purge_expunged_vms.py
test_02_purge_expunged_api_vm_end_date	`Error`	4248.79	test_purge_expunged_vms.py
test_03_purge_expunged_api_vm_start_end_date	`Error`	4209.00	test_purge_expunged_vms.py
test_04_purge_expunged_api_vm_no_date	`Error`	4268.95	test_purge_expunged_vms.py
test_05_purge_expunged_vm_service_offering	`Error`	3605.92	test_purge_expunged_vms.py
test_06_purge_expunged_vm_background_task	`Error`	301.48	test_purge_expunged_vms.py
test_01_restore_vm	`Error`	0.14	test_restore_vm.py
test_02_restore_vm_allocated_root	`Error`	0.12	test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown	`Error`	1.20	test_restore_vm.py

blueorangutan · 2024-05-02T11:48:46Z

[SF] Trillian test result (tid-10111)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 95985 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8999-t10111-kvm-centos7.zip
Smoke tests completed. 129 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	417.66	test_events_resource.py
test_01_purge_expunged_api_vm_start_date	`Failure`	3861.52	test_purge_expunged_vms.py
test_02_purge_expunged_api_vm_end_date	`Error`	4266.43	test_purge_expunged_vms.py
test_03_purge_expunged_api_vm_start_end_date	`Error`	4270.05	test_purge_expunged_vms.py
test_04_purge_expunged_api_vm_no_date	`Error`	4269.15	test_purge_expunged_vms.py
test_05_purge_expunged_vm_service_offering	`Error`	3666.85	test_purge_expunged_vms.py
test_06_purge_expunged_vm_background_task	`Error`	3907.16	test_purge_expunged_vms.py
test_01_restore_vm	`Error`	0.21	test_restore_vm.py
test_02_restore_vm_allocated_root	`Error`	0.13	test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown	`Error`	1.21	test_restore_vm.py

blueorangutan · 2024-05-02T13:26:53Z

[SF] Trillian test result (tid-10110)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 101993 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8999-t10110-vmware-67u3.zip
Smoke tests completed. 129 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	338.69	test_events_resource.py
test_01_purge_expunged_api_vm_start_date	`Failure`	3936.51	test_purge_expunged_vms.py
test_02_purge_expunged_api_vm_end_date	`Error`	4217.48	test_purge_expunged_vms.py
test_03_purge_expunged_api_vm_start_end_date	`Error`	4264.67	test_purge_expunged_vms.py
test_04_purge_expunged_api_vm_no_date	`Error`	4266.45	test_purge_expunged_vms.py
test_05_purge_expunged_vm_service_offering	`Error`	3605.18	test_purge_expunged_vms.py
test_06_purge_expunged_vm_background_task	`Error`	3964.82	test_purge_expunged_vms.py
test_01_restore_vm	`Error`	0.23	test_restore_vm.py
test_02_restore_vm_allocated_root	`Error`	0.28	test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown	`Error`	1.38	test_restore_vm.py

shwstppr · 2024-05-02T16:51:20Z

@blueorangutan test keepEnv

blueorangutan · 2024-05-02T16:52:03Z

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-05-02T18:38:59Z

[LL] Trillian Build Failed (tid-6926)

blueorangutan · 2024-05-03T21:57:08Z

[SF] Trillian test result (tid-10145)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 102908 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8999-t10145-kvm-centos7.zip
Smoke tests completed. 128 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	416.19	test_events_resource.py
test_01_purge_expunged_api_vm_start_date	`Failure`	3867.81	test_purge_expunged_vms.py
test_02_purge_expunged_api_vm_end_date	`Error`	4209.15	test_purge_expunged_vms.py
test_03_purge_expunged_api_vm_start_end_date	`Error`	4270.12	test_purge_expunged_vms.py
test_04_purge_expunged_api_vm_no_date	`Error`	4214.86	test_purge_expunged_vms.py
test_05_purge_expunged_vm_service_offering	`Error`	3667.20	test_purge_expunged_vms.py
test_06_purge_expunged_vm_background_task	`Error`	3911.95	test_purge_expunged_vms.py
test_01_restore_vm	`Error`	0.24	test_restore_vm.py
test_02_restore_vm_allocated_root	`Error`	0.17	test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown	`Error`	1.26	test_restore_vm.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	453.99	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	519.47	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	519.49	test_vpc_redundant.py

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2024-05-05T19:26:46Z

@blueorangutan package

blueorangutan · 2024-05-05T19:28:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-05-05T20:36:22Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9539

shwstppr · 2024-05-05T20:43:56Z

@blueorangutan test keepEnv

blueorangutan · 2024-05-05T20:46:03Z

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-05-05T21:04:40Z

[SF] Trillian Build Failed (tid-10163)

shwstppr · 2024-05-06T03:50:05Z

@blueorangutan test keepEnv

blueorangutan · 2024-05-06T03:52:03Z

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-05-06T17:10:50Z

[SF] Trillian test result (tid-10165)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46189 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8999-t10165-kvm-centos7.zip
Smoke tests completed. 130 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	425.07	test_events_resource.py
test_01_restore_vm	`Error`	0.22	test_restore_vm.py
test_02_restore_vm_allocated_root	`Error`	0.15	test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown	`Error`	1.25	test_restore_vm.py

...src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java

...rc/main/java/org/apache/cloudstack/api/command/admin/resource/PurgeExpungedResourcesCmd.java

api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java

…ring/CreateServiceOfferingCmd.java Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

…urce/PurgeExpungedResourcesCmd.java Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

…feringResponse.java Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

sureshanaparti · 2024-05-08T05:15:11Z

api/src/main/java/org/apache/cloudstack/resource/ResourceCleanupService.java

+                    "format \"yyyy-MM-dd\" or \"yyyy-MM-dd HH:mm:ss\"", true);
+    ConfigKey<Integer> ExpungedResourcesPurgeKeepPastDays = new ConfigKey<>("Advanced", Integer.class,
+            "expunged.resources.purge.keep.past.days", "30",
+            "The number of days in the past from the execution time of the background task to purge " +


Suggested change

"The number of days in the past from the execution time of the background task to purge " +

"The number of days in the past from the execution time of the background task to keep " +

I guess the complete sentence makes sense as it is,

The number of days in the past from the execution time of the background task to purge the expunged resources for which the expunged resources must not be purged

If needed, we can rephrase the whole statement

sureshanaparti

code lgtm

shwstppr · 2024-05-08T05:52:51Z

@blueorangutan package

blueorangutan · 2024-05-08T05:54:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-05-08T07:15:06Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9573

boring-cyborg bot added component:api component:compute component:integration component:networking component:orchestration labels Apr 29, 2024

shwstppr added a commit to shapeblue/cloudstack-documentation that referenced this pull request Apr 29, 2024

notes on purging expunged resources

3735d92

Feature PR: apache/cloudstack#8999 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr mentioned this pull request Apr 29, 2024

notes on purging expunged resources apache/cloudstack-documentation#397

Open

shwstppr force-pushed the feature-purgedb branch from 62df9e1 to af9d68c Compare April 30, 2024 06:31

shwstppr added 2 commits April 30, 2024 18:56

fix

8ee1a15

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

refactor

971991d

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

fix

3103f85

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

another fix

f8fc404

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr added 2 commits May 6, 2024 00:40

fixes

f0c04cb

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

test fix

73770a5

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

apache deleted a comment from blueorangutan May 5, 2024

sureshanaparti reviewed May 8, 2024

View reviewed changes

...src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java Outdated Show resolved Hide resolved

sureshanaparti reviewed May 8, 2024

View reviewed changes

...rc/main/java/org/apache/cloudstack/api/command/admin/resource/PurgeExpungedResourcesCmd.java Outdated Show resolved Hide resolved

sureshanaparti reviewed May 8, 2024

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java Outdated Show resolved Hide resolved

shwstppr and others added 3 commits May 8, 2024 10:35

Update api/src/main/java/org/apache/cloudstack/api/command/admin/offe…

7fd0c4e

…ring/CreateServiceOfferingCmd.java Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

Update api/src/main/java/org/apache/cloudstack/api/command/admin/reso…

00ca064

…urce/PurgeExpungedResourcesCmd.java Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

Update api/src/main/java/org/apache/cloudstack/api/response/ServiceOf…

8bca921

…feringResponse.java Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

sureshanaparti reviewed May 8, 2024

View reviewed changes

sureshanaparti approved these changes May 8, 2024

View reviewed changes

	"The number of days in the past from the execution time of the background task to purge " +
	"The number of days in the past from the execution time of the background task to keep " +

api,server: purge expunged resources #8999

Are you sure you want to change the base?

api,server: purge expunged resources #8999

Conversation

shwstppr commented Apr 29, 2024 • edited

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov-commenter commented Apr 29, 2024 • edited

Codecov Report

shwstppr commented Apr 29, 2024

blueorangutan commented Apr 29, 2024

blueorangutan commented Apr 29, 2024

shwstppr commented Apr 29, 2024

blueorangutan commented Apr 29, 2024

blueorangutan commented Apr 29, 2024

shwstppr commented Apr 30, 2024

blueorangutan commented Apr 30, 2024

blueorangutan commented Apr 30, 2024

blueorangutan commented Apr 30, 2024

shwstppr commented Apr 30, 2024

blueorangutan commented Apr 30, 2024

blueorangutan commented Apr 30, 2024

shwstppr commented Apr 30, 2024

blueorangutan commented Apr 30, 2024

blueorangutan commented Apr 30, 2024

blueorangutan commented May 2, 2024

blueorangutan commented May 2, 2024

blueorangutan commented May 2, 2024

shwstppr commented May 2, 2024

blueorangutan commented May 2, 2024

blueorangutan commented May 2, 2024

blueorangutan commented May 3, 2024

shwstppr commented May 5, 2024

blueorangutan commented May 5, 2024

blueorangutan commented May 5, 2024

shwstppr commented May 5, 2024

blueorangutan commented May 5, 2024

blueorangutan commented May 5, 2024

shwstppr commented May 6, 2024

blueorangutan commented May 6, 2024

blueorangutan commented May 6, 2024

sureshanaparti May 8, 2024

Choose a reason for hiding this comment

shwstppr May 8, 2024

Choose a reason for hiding this comment

sureshanaparti left a comment

Choose a reason for hiding this comment

shwstppr commented May 8, 2024

blueorangutan commented May 8, 2024

blueorangutan commented May 8, 2024

shwstppr commented Apr 29, 2024 •

edited

codecov-commenter commented Apr 29, 2024 •

edited