Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-20624: Fix bug in camel-http to avoid duplicate OAuth2 Authorization headers #13629

Merged
merged 1 commit into from Mar 28, 2024

Conversation

joshuagrisham-karolinska
Copy link
Contributor

@joshuagrisham-karolinska joshuagrisham-karolinska commented Mar 27, 2024

Description

Uses HttpRequest setHeader instead of addHeader to ensure that duplicate of "Authorization" header will not be created when using camel-http's OAuth2 support. See: https://hc.apache.org/httpcomponents-core-5.1.x/current/httpcore5/apidocs/org/apache/hc/core5/http/HttpMessage.html#setHeader(org.apache.hc.core5.http.Header)

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@davsclaus davsclaus merged commit 8b2bdb1 into apache:main Mar 28, 2024
5 checks passed
davsclaus pushed a commit that referenced this pull request Mar 28, 2024
@joshuagrisham-karolinska joshuagrisham-karolinska deleted the CAMEL-20624 branch March 28, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants