Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-19164: upgrade to http components 5.x #13619

Merged

Conversation

jono-morris
Copy link
Contributor

Description

Upgrade camel-as2 to use httpcomponents v5.

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@jono-morris
Copy link
Contributor Author

jono-morris commented Mar 26, 2024

/component-test as2

Result ✅ The tests passed successfully

Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably good to run a manual full test of this one ... I'll trigger a test on my env

@davsclaus
Copy link
Contributor

Thanks @jono-morris - there are some other tickets about camel-as2 that would be good to take a look at

@davsclaus
Copy link
Contributor

@orpiske have you done your tests

@orpiske
Copy link
Contributor

orpiske commented Mar 28, 2024

@orpiske have you done your tests

Oh, I almost forgot about this one ... thanks for the heads up.

Looking at the results, I noticed that the build has failed with an execution timeout. I don't think it's caused by this PR specifically, but because it may be lagging behind main (which had some fixes for this). So, in short, I cannot say for sure if it's working or not.

@davsclaus
Copy link
Contributor

okay lets merge this as we need to move to http 5.x anyway and camel-as2 needs some cleanup and there are other JIRAs related to issues with camel-as2.

@davsclaus davsclaus merged commit fbee8b0 into apache:main Mar 29, 2024
5 checks passed
@jono-morris jono-morris deleted the CAMEL-19164_upgrade_to_HttpComponents_5.x branch March 29, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants