Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camel-cdi remove deprecated fireEvent method #13596

Merged
merged 1 commit into from Mar 28, 2024

Conversation

mariucojocaru
Copy link

  • remove deprecated BeanManager.fireEvent
  • this will allow the library to be used in also with cdi api 4 after transforming it with eclipse transformer.

Description

fireEvent method was removed in cdi api 4 version. This means the camel-cdi library cannot be used in jakarta app servers even after transforming it using eclipse transformer tool.

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

- remove deprecated BeanManager.fireEvent
- this will allow the library to be used in also
  with cdi api 4 after transforming it with eclipse transformer.
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

⚠️ Please note that the changes on this PR may be tested automatically.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@davsclaus
Copy link
Contributor

Can you create a JIRA and send a PR for 3.22.x branch only.

@mariucojocaru
Copy link
Author

Can you create a JIRA and send a PR for 3.22.x branch only.

Thanks for your feedback. I will do so. I do not have yet a jira account to create the ticket, so might take a while.

Copy link
Contributor

Components test results:

Total Tested Failed ❌ Passed ✅
1 1 0 1

Copy link
Contributor

🚫 There are (likely) no changes in core core to be tested in this PR

@davsclaus
Copy link
Contributor

I created a ticket
https://issues.apache.org/jira/browse/CAMEL-20627

@davsclaus davsclaus merged commit 0b3d2c9 into apache:camel-3.21.x Mar 28, 2024
4 of 5 checks passed
davsclaus pushed a commit that referenced this pull request Mar 28, 2024
CAMEL-20627: remove deprecated BeanManager.fireEvent this will allow the library to be used in also with cdi api 4 after transforming it with eclipse transformer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants