Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-20602: Support user properties on Camel JBang bind command #13593

Merged

Conversation

christophd
Copy link
Contributor

@christophd christophd commented Mar 22, 2024

Description

CAMEL-20602

  • Allow to specify properties on source, sink, step in a Pipe
  • User properties can be set as additional command options targeting either the source or the sink or a specific step

This PR adds a new option to the Camel JBang bind command --property. Users can set properties on source, sink or steps with this syntax:

camel bind timer-to-log --source timer-source --sink log-sink --property source.message=Hello --property sink.showHeaders=false

This will result in the Pipe using the properties on the source and sink.

apiVersion: camel.apache.org/v1
kind: Pipe
metadata:
  name: timer-to-log
spec:
  source:
    ref:
      kind: Kamelet
      apiVersion: camel.apache.org/v1
      name: timer-source
    properties:
      message: Hello
  sink:
    ref:
      kind: Kamelet
      apiVersion: camel.apache.org/v1
      name: log-sink
    properties:
      showHeaders: true

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

See CAMEL-20602

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@christophd christophd force-pushed the issue/CAMEL-20602/bind-user-properties branch 2 times, most recently from 5de8934 to 9f70818 Compare March 22, 2024 16:17
- Allow to specify properties on source, sink, step in a Pipe
- User properties can be set as additional command options targeting either the source or the sink or a specific step
@christophd christophd force-pushed the issue/CAMEL-20602/bind-user-properties branch from 9f70818 to 6c675a2 Compare March 22, 2024 16:28
@christophd christophd merged commit 17175a0 into apache:main Mar 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants