Skip to content

Commit

Permalink
CAMEL-20523: camel-xpath - The resultQName converter is wrong causing… (
Browse files Browse the repository at this point in the history
#13389)

CAMEL-20523: camel-xpath - The resultQName converter is wrong causing CSB not to work with xpath in language endpoint
  • Loading branch information
davsclaus committed Mar 6, 2024
1 parent 520c81c commit 622e12e
Show file tree
Hide file tree
Showing 2 changed files with 73 additions and 0 deletions.
@@ -0,0 +1,61 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.camel.language;

import javax.xml.namespace.QName;
import javax.xml.xpath.XPathConstants;

import org.apache.camel.ContextTestSupport;
import org.apache.camel.Exchange;
import org.apache.camel.builder.RouteBuilder;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

public class XPathLanguageEndpointTest extends ContextTestSupport {

@Test
public void testXPath() throws Exception {
getMockEndpoint("mock:result").expectedBodiesReceived("Hello World");

template.sendBody("direct:start", "<foo>Hello World</foo>");

assertMockEndpointsSatisfied();

// test converter also works with shorthand names
QName qn = context.getTypeConverter().convertTo(QName.class, "NODESET");
Assertions.assertEquals(XPathConstants.NODESET, qn);
qn = context.getTypeConverter().convertTo(QName.class, "nodeset");
Assertions.assertEquals(XPathConstants.NODESET, qn);
qn = context.getTypeConverter().convertTo(QName.class, "BOOLEAN");
Assertions.assertEquals(XPathConstants.BOOLEAN, qn);
qn = context.getTypeConverter().convertTo(QName.class, "boolean");
Assertions.assertEquals(XPathConstants.BOOLEAN, qn);
}

@Override
protected RouteBuilder createRouteBuilder() throws Exception {
return new RouteBuilder() {
@Override
public void configure() throws Exception {
from("direct:start")
.setHeader(Exchange.LANGUAGE_SCRIPT, constant("/foo/text()"))
.to("language:xpath")
.to("mock:result");
}
};
}
}
Expand Up @@ -57,6 +57,7 @@
import javax.xml.transform.stax.StAXSource;
import javax.xml.transform.stream.StreamResult;
import javax.xml.transform.stream.StreamSource;
import javax.xml.xpath.XPathConstants;

import org.w3c.dom.Document;
import org.w3c.dom.Element;
Expand Down Expand Up @@ -146,6 +147,17 @@ public void toResult(Source source, Result result, Properties outputProperties)
*/
@Converter(order = 1)
public QName toQName(String str) {
if ("NUMBER".equalsIgnoreCase(str)) {
return XPathConstants.NUMBER;
} else if ("STRING".equalsIgnoreCase(str)) {
return XPathConstants.STRING;
} else if ("BOOLEAN".equalsIgnoreCase(str)) {
return XPathConstants.BOOLEAN;
} else if ("NODESET".equalsIgnoreCase(str)) {
return XPathConstants.NODESET;
} else if ("NODE".equalsIgnoreCase(str)) {
return XPathConstants.NODE;
}
return QName.valueOf(str);
}

Expand Down

0 comments on commit 622e12e

Please sign in to comment.