Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initial support for camel-k #1097

Merged
merged 1 commit into from Mar 4, 2024
Merged

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Feb 29, 2024

@lburgazzoli lburgazzoli marked this pull request as ready for review March 4, 2024 13:05
@lburgazzoli
Copy link
Contributor Author

Looks like there are some issues related to openapi v2 rmeoval

[INFO] Running org.apache.camel.openapi.RestOpenApiReaderTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.058 s <<< FAILURE! -- in org.apache.camel.openapi.RestOpenApiReaderTest
[ERROR] org.apache.camel.openapi.RestOpenApiReaderTest.testReaderRead -- Time elapsed: 0.010 s <<< ERROR!
java.lang.IllegalArgumentException: OpenAPI 2.x is not supported
	at org.apache.camel.openapi.RestOpenApiReader.checkCompatOpenApi2(RestOpenApiReader.java:182)
	at org.apache.camel.openapi.RestOpenApiReader.read(RestOpenApiReader.java:176)
	at org.apache.camel.openapi.RestOpenApiReaderTest.testReaderRead(RestOpenApiReaderTest.java:105)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@davsclaus
Copy link
Contributor

Are you on old code ?

@lburgazzoli
Copy link
Contributor Author

@davsclaus
Copy link
Contributor

Ah sorry its those darn test copy from core, that have little value and get out of date

@davsclaus
Copy link
Contributor

fixing this now

@davsclaus
Copy link
Contributor

pushed fix

@lburgazzoli
Copy link
Contributor Author

ok so now failures are because there is no yet a -SNAPSHOT ready

@davsclaus
Copy link
Contributor

There was some leftover in the camel-spring-boot core module. If this gets reverted then this PR is only adding a new camel-k module, and then its perfect fine to merged.

@davsclaus davsclaus merged commit 8309994 into apache:main Mar 4, 2024
2 checks passed
@lburgazzoli lburgazzoli deleted the camel-k branch March 4, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants